Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message generation #11

Open
ruffsl opened this issue Mar 5, 2019 · 3 comments
Open

Improve message generation #11

ruffsl opened this issue Mar 5, 2019 · 3 comments

Comments

@ruffsl
Copy link
Contributor

ruffsl commented Mar 5, 2019

Having to include and recompile all the message types any rust project requires is kind of a non-starter:

"Ain't Nobody Got Time for That"
~ Kimberly "Sweet Brown" Wilkins

Are there anyways we can improve upon this, like upstreaming rosidl_generator_rs as one of the default IDL generators, or reusing IDL files generated from rosidl_generator_c? How have other client libraries such as rclpy worked around this? Are there memory safety considerations we should account for? Already I've encountered memory leaks using rclrs that could have been prevented by rustc and RAII.

@esteve
Copy link
Collaborator

esteve commented Mar 19, 2019

How have other client libraries such as rclpy worked around this?

I can't speak for other client libraries, but definitely can for rclpy. rclpy hasn't worked around this issue, it just happens to be included upstream, but there are no mechanisms in rclpy for not regenerating messages.

Are there memory safety considerations we should account for? Already I've encountered memory leaks using rclrs that could have been prevented by rustc and RAII.

Could you file a ticket with an example so we can address this? Thanks.

@nnmm
Copy link
Contributor

nnmm commented Apr 22, 2022

Having to include and recompile all the message types any rust project requires is kind of a non-starter

I'm not sure if we should try to do something about this (not sure if it's possible?), or simply hope we'll get included into ROS 2 proper and have rosidl_generator_rs become a default generator.

The other points in this issue have been addressed, I think.

@nnmm
Copy link
Contributor

nnmm commented May 28, 2022

@esteve what do you think about my previous comment? Can this issue be closed as "won't fix until rosidl_generator_rs is included in the ROS 2 distribution?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants