diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index e6f015e6d..3fd48dba0 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -101,7 +101,7 @@ jobs: run: | cd ${{ steps.build.outputs.ros-workspace-directory-name }} . install/setup.sh - for path in $(colcon list | awk '$3 == "(ament_cargo)" && $1 != "examples_rclrs_minimal_pub_sub" && $1 != "examples_rclrs_minimal_client_service" { print $2 }'); do + for path in $(colcon list | awk '$3 == "(ament_cargo)" && $1 != "examples_rclrs_minimal_pub_sub" && $1 != "examples_rclrs_minimal_client_service" && $1 != "rust_pubsub" { print $2 }'); do cd $path echo "Running cargo test in $path" # Run cargo test for all features except generate_docs (needed for docs.rs) @@ -119,7 +119,7 @@ jobs: run: | cd ${{ steps.build.outputs.ros-workspace-directory-name }} . /opt/ros/${{ matrix.ros_distribution }}/setup.sh - for path in $(colcon list | awk '$3 == "(ament_cargo)" && $1 != "examples_rclrs_minimal_pub_sub" && $1 != "examples_rclrs_minimal_client_service" { print $2 }'); do + for path in $(colcon list | awk '$3 == "(ament_cargo)" && $1 != "examples_rclrs_minimal_pub_sub" && $1 != "examples_rclrs_minimal_client_service" && $1 != "rust_pubsub" { print $2 }'); do cd $path echo "Running rustdoc check in $path" cargo rustdoc -- -D warnings diff --git a/docs/writing_a_simple_publisher_and_subscriber.md b/docs/writing_a_simple_publisher_and_subscriber.md new file mode 100644 index 000000000..a666ba80f --- /dev/null +++ b/docs/writing_a_simple_publisher_and_subscriber.md @@ -0,0 +1,469 @@ +# Writing a simple publisher and subscriber (Rust) +* Goal: Create and run a publisher and subscriber node using Rust. +* Tutorial level: Beginner +* Time: 20 minutes +
Background + +In this tutorial you will create a pair of +[nodes](https://docs.ros.org/en/humble/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Nodes/Understanding-ROS2-Nodes.html) that pass information to each other via a +[topic](https://docs.ros.org/en/humble/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Topics/Understanding-ROS2-Topics.html) in the form of string messages. The example used here is a simple "talker" and "listener" system; one node publishes data and the other subscribes to the topic to receive that data. + +Since Rust doesn't have inheritance, it's not possible to inherit from `Node` as is common practice in [`rclcpp`](https://docs.ros.org/en/humble/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.html) or [`rclpy`](https://docs.ros.org/en/humble/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Py-Publisher-And-Subscriber.html). + +The code used in these examples can be found [here](https://github.com/ros2-rust/ros2_rust/tree/main/examples/rust_pubsub) +
+
Side-note on dependencies + +You may be wondering why you can't just add all your ROS 2-specific dependencies to `Cargo.toml` with `cargo add YOUR_DEPENDENCIES` and have to edit this file manually. Here is why: +Almost none of the ROS 2 dependencies you'll need for your ROS 2 Rust node development currently exist on [crates.io](https://crates.io/), the +main source for Rust dependencies. So the add command simply can't find the dependency targets. What colcon does by compiling +the ROS 2 Rust dependencies and your ROS 2 Rust project is redirect the cargo search for dependencies directly into your +`workspace/install` folder, where it'll find locally generated Rust projects to use as dependencies. In particular, almost +all message types will be called as dependencies for your ROS 2 Rust project this way. + +
+ +
+ +
Prerequisites + +Basic concepts of development with ROS 2 should be known: +* [workspaces](https://docs.ros.org/en/humble/Tutorials/Beginner-Client-Libraries/Creating-A-Workspace/Creating-A-Workspace.html) +* [packages](https://docs.ros.org/en/humble/Tutorials/Beginner-Client-Libraries/Creating-Your-First-ROS2-Package.html). + +A basic understanding of [Rust](https://doc.rust-lang.org/book/) is recommended, but not entirely necessary. +Before developing [ros2-rust](https://github.com/ros2-rust/ros2_rust) nodes, you must follow the +[installation instructions](https://github.com/ros2-rust/ros2-rust/blob/main/README.md) for [`rclrs`](https://docs.rs/rclrs/latest/rclrs/). +For a full Introduction into Rust, please read the very good [Rust book](https://doc.rust-lang.org/book/title-page.html). + +
+ +
Tasks +
Create a Package + +Currently, building a package for ros2-rust is different +from building packages for [Python](https://docs.ros.org/en/humble/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Py-Publisher-And-Subscriber.html) or [C/C++](https://docs.ros.org/en/humble/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Publisher-And-Subscriber.html). + +First, you'll need to create a standard [cargo](https://doc.rust-lang.org/cargo/) +package: +```sh +cargo new rust_pubsub && cd rust_pubsub +``` +In the [`Cargo.toml`](https://doc.rust-lang.org/book/ch01-03-hello-cargo.html) file, add a dependency on `rclrs = "*"` and `std_msgs = "*"` by editing this file. Your `Cargo.toml` should now look like this: +```toml +[package] +name = "rust_pubsub" +version = "0.1.0" +edition = "2021" +[dependencies] +rclrs = "*" +std_msgs = "*" +``` +Additionally, create a new `package.xml` if you want your node to be buildable with [`colcon`](https://colcon.readthedocs.io/en/released/user/installation.html). Make sure to change the build type to `ament_cargo` and to include the two packages mentioned above in the dependencies, as such: +```xml + + rust_pubsub + 0.0.0 + TODO: Package description. + user + TODO: License declaration. + + rclrs + std_msgs + + + ament_cargo + + +``` +Your package should now have a similar structure: +```sh +├── Cargo.toml +├── package.xml +└── src + └── main.rs +``` + +
+ +
Write the publisher node + +To construct a node, replace the code in your `main.rs` file with the following: +```rust +/// Creates a SimplePublisherNode, initializes a node and publisher, and provides +/// methods to publish a simple "Hello World" message on a loop in separate threads. + +use rclrs::{create_node, Context, Node, Publisher, RclrsError, QOS_PROFILE_DEFAULT}; +use std::{env, sync::Arc, thread, time::Duration}; +use std_msgs::msg::String as StringMsg; +/// SimplePublisherNode struct contains node and publisher members. +/// Used to initialize a ROS 2 node and publisher, and publish messages. +struct SimplePublisherNode { + node: Arc, + publisher: Arc>, +} +impl SimplePublisherNode { + fn new(context: &context) -> result { + let node = create_node(context, "simple_publisher").unwrap(); + let publisher = node + .create_publisher("publish_hello", qos_profile_default) + .unwrap(); + ok(self { node, publisher }) + } + fn publish_data(&self, increment: i32) -> Result { + let msg: StringMsg = StringMsg { + data: format!("Hello World {}", increment), + }; + self.publisher.publish(msg).unwrap(); + Ok(increment + 1_i32) + } +} +fn main() -> Result<(), RclrsError> { + let context = Context::new(env::args()).unwrap(); + let publisher = Arc::new(SimplePublisherNode::new(&context).unwrap()); + let publisher_other_thread = Arc::clone(&publisher); + let mut count: i32 = 0; + thread::spawn(move || loop { + thread::sleep(Duration::from_millis(1000)); + count = publisher_other_thread.publish_data(count).unwrap(); + }); + rclrs::spin(publisher.node.clone()) +} +``` + +
Examining the code in detail: + +#### Importing +The first 3 lines of the Rust code imports tools for thread synchronization, time +handling, iteration, threading, ROS 2 communication, and string message publishing. +```rust +use rclrs::{create_node, Context, Node, Publisher, RclrsError, QOS_PROFILE_DEFAULT}; +use std::{env, sync::Arc, thread, time::Duration}; +use std_msgs::msg::String as StringMsg; +``` +* `use std::{sync::Arc, time::Duration, iter, thread};`: Imports specific features from the standard library: + - `Arc` is for thread-safe shared ownership of data. + - `Duration` represents a time span. + - `thread` enables creating and managing threads. +* `use rclrs::{RclrsError, QOS_PROFILE_DEFAULT, Context, create_node, Node, Publisher};`: + - Imports elements for ROS 2 communication: + - `RclrsError` for handling errors. + - `QOS_PROFILE_DEFAULT` for default Quality of Service settings. +- `Context, create_node, Node, Publisher` are for ROS 2 node creation and publishing. +* `use std_msgs::msg::String as StringMsg;`: Imports the `StringMsg` type for publishing string messages. + +#### `SimplePublisherNode` +Next, this structure defines a `SimplePublisherNode` which holds references to a ROS 2 node and a publisher for string messages. +```rust +struct SimplePublisherNode { + node: Arc, + publisher: Arc>, +} +``` +1. Structure: +`struct SimplePublisherNode`: This line defines a new [`struct`](https://doc.rust-lang.org/rust-by-example/custom_types/structs.html) named `SimplePublisherNode`. It serves as a blueprint for creating objects that hold information related to a simple publisher node in ROS 2. + +2. Members: +* `node: Arc`: This member stores a reference to a ROS 2 node, wrapped in an [`Arc` (Atomic Reference Counted)](https://doc.rust-lang.org/std/sync/struct.Arc.html) smart pointer. This allows for safe sharing of the node reference across multiple threads. +* `_publisher: Arc>`: This member stores a reference to a publisher specifically for string messages (`StringMsg`), also wrapped in an `Arc` for thread safety. The publisher is responsible for sending string messages to other nodes in the ROS 2 system. +#### `impl SimplePublisher` +This code defines methods for the `SimplePublisherNode` `struct`. The `new` method creates a ROS 2 node and publisher, storing them in the `struct`. The `publish_data` method publishes a string message with a `counter` and returns the incremented `counter`. +```rust +impl SimplePublisherNode { + fn new(context: &context) -> result { + let node = create_node(context, "simple_publisher").unwrap(); + let publisher = node + .create_publisher("publish_hello", qos_profile_default) + .unwrap(); + ok(self { node, publisher }) + } + fn publish_data(&self, increment: i32) -> Result { + let msg: StringMsg = StringMsg { + data: format!("Hello World {}", increment), + }; + self.publisher.publish(msg).unwrap(); + Ok(increment + 1_i32) + } +} +``` + +1. Implementation Block: +`impl SimplePublisherNode { ... }`: This line indicates that methods are being defined for the `SimplePublisherNode` struct. +2. Constructor Method: +* `fn new(context: &Context) -> Result { ... }`: This method serves as a constructor for creating instances of `SimplePublisherNode`. + * It takes a Context object as input, which is necessary for interacting with the ROS 2 system. + * It returns a Result type, indicating either a successful Self (the created `SimplePublisherNode` object) or an `RclrsError` if something goes wrong. + * Inside the new method: + * `let node = create_node(context, "simple_publisher").unwrap();`: Creates a new ROS 2 node named `"simple_publisher"` within the given context. The [`unwrap()`](https://doc.rust-lang.org/rust-by-example/error/option_unwrap.html) unwraps the [`Result`](https://doc.rust-lang.org/std/result/), handling any errors immediately by forcing the program to abort ([`panic`](https://doc.rust-lang.org/book/ch09-01-unrecoverable-errors-with-panic.html)) if something goes wrong. Since your code can't function properly if the node is not able to be created, this is a valid error-handling response for our use-case. + * `let _publisher = node.create_publisher("publish_hello", QOS_PROFILE_DEFAULT).unwrap();`: Creates a publisher for string messages on the topic `"publish_hello"` with default quality of service settings. + * `Ok(Self { node, _publisher, })`: Returns an [`Ok(T)`](https://doc.rust-lang.org/std/result/) Result with the newly created `SimplePublisherNode` as `T` object, containing the node and publisher references. +3. Publishing Method: +* `fn publish_data(&self, increment: i32) -> Result { ... }`: This method publishes a string message and increments a `counter`. + * It takes an increment value (an integer) as input, which is used for counting purposes within the message content. + * It also returns a Result type, indicating either the incremented value or an [`RclrsError`](https://docs.rs/rclrs/latest/rclrs/enum.RclrsError.html) if publishing fails. + * Inside the publish_data method: + * `let msg: StringMsg = StringMsg { data: format!("Hello World {}", increment), };`: Creates a string message with the content `"Hello World"` followed by the increment value. + * `self._publisher.publish(msg).unwrap();`: Publishes the created message onto the topic associated with the publisher. + * `Ok(increment + 1_i32)`: Returns a Result with the incremented increment value. + +#### main +The main Method creates a ROS 2 node that publishes string messages at a rate of 1 Hz. +```rust +fn main() -> Result<(), RclrsError> { + let context = Context::new(env::args()).unwrap(); + let publisher = Arc::new(SimplePublisherNode::new(&context).unwrap()); + let publisher_other_thread = Arc::clone(&publisher); + let mut count: i32 = 0; + thread::spawn(move || loop { + thread::sleep(Duration::from_millis(1000)); + count = publisher_other_thread.publish_data(count).unwrap(); + }); + rclrs::spin(publisher.node.clone()) +} +``` + +1. Main Function: +`fn main() -> Result<(), RclrsError> { ... }`: This defines the main entry point of the program. It returns a [`Result`](https://doc.rust-lang.org/std/result/) type, indicating either successful execution or an [`RclrsError`](https://docs.rs/rclrs/latest/rclrs/enum.RclrsError.html). +2. Context and Node Setup: +* `let context = Context::new(std::env::args()).unwrap();`: Creates a ROS 2 context using command-line arguments. +* `let publisher = Arc::new(SimplePublisherNode::new(&context).unwrap());`: + * Creates an [Arc (atomic reference counted)](https://doc.rust-lang.org/std/sync/struct.Arc.html) pointer to a `SimplePublisherNode` object. + * Calls the new method on `SimplePublisherNode` to construct the node and publisher within the context. +3. Thread and Iterator: +* `let publisher_other_thread = Arc::clone(&publisher);`: Clones the shared publisher pointer for use in a separate thread. +* `let mut iterator: i32 = 0;`: Initializes a counter variable for message content. +* `thread::spawn(move || -> () { ... });`: Spawns a new [thread](https://doc.rust-lang.org/std/thread/index.html) with a [closure](https://doc.rust-lang.org/book/ch13-01-closures.html): `loop { ... }`: Creates an infinite loop using [`loop`](https://doc.rust-lang.org/std/keyword.loop.html). +4. Publishing Loop within Thread: +* `thread::sleep(Duration::from_millis(1000));`: Pauses the thread for 1 second (1 Hz publishing rate). +* `iterator = publisher_other_thread.publish_data(count).unwrap();`: Calls the `publish_data` method on the `publisher_other_thread` to publish a message with the current counter value. Increments the iterator for the next message. +5. Main Thread Spin: +* `rclrs::spin(publisher.node.clone());`: Keeps the main thread running, processing ROS 2 events and messages. Uses a cloned reference to the node to ensure it remains active even with other threads. + +
+
+
Having several ROS 2 Rust nodes in one Package + +Of course, you can write for each node you want to implement its own package, and that can have it's advantages. I implore you to use some cargo tricks and add some binary targets to your `cargo.toml`. That could look like this: +```toml +[package] +name = "rust_pubsub" +version = "0.1.0" +edition = "2021" + +# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html + +[[bin]] +name="simple_publisher" +path="src/simple_publisher.rs" +[dependencies] +rclrs = "*" +std_msgs = "*" +``` + +You'll find the name of your executable and the corresponding file name under the `[[bin]]` tag. As you can see, the filename and the name you want to call your node don't have to match. Please remember to include your executable name with snake_cases. The Rust compiler will be a bit grumpy if you don't. +Now, by recompiling the package from the previous chapter and making it usable: +```sh +cd WORKSPACE +colcon build +source install/setub.bash +``` +Running the node will look like this: +```sh +ros2 run rust_pubsub simple_publisher +``` +As you can see, you are now calling your node by the name declared in `[[bin]]` using the `name` variable. + +
+
Write the subscriber node + +Of course, you can implement a new ROS 2 Rust package for this node. You can find out how to do this in the section called 'Create a package'. +Or you can add a new binary target to your package. To do so, just add a new `FILE.rs` to your source directory - for simplicity I'll call this file `simple_subscriber.rs` - and add a corresponding binary target to your `Cargo.toml`: +```toml +[[bin]] +name="simple_subscriber" +path="src/simple_subscriber.rs" +``` +To construct the subscriber node, put the following code into a `FILE.rs` - in my case its the `src/simple_subscriber.rs`: +```rust +use rclrs::{create_node, Context, Node, RclrsError, Subscription, QOS_PROFILE_DEFAULT}; +use std::{ + env, + sync::{Arc, Mutex}, + thread, + time::Duration, +}; +use std_msgs::msg::String as StringMsg; +pub struct SimpleSubscriptionNode { + node: Arc, + _subscriber: Arc>, + data: Arc>>, +} +impl SimpleSubscriptionNode { + fn new(context: &Context) -> Result { + let node = create_node(context, "simple_subscription").unwrap(); + let data: Arc>> = Arc::new(Mutex::new(None)); + let data_mut: Arc>> = Arc::clone(&data); + let _subscriber = node + .create_subscription::( + "publish_hello", + QOS_PROFILE_DEFAULT, + move |msg: StringMsg| { + *data_mut.lock().unwrap() = Some(msg); + }, + ) + .unwrap(); + Ok(Self { + node, + _subscriber, + data, + }) + } + fn data_callback(&self) -> Result<(), RclrsError> { + if let Some(data) = self.data.lock().unwrap().as_ref() { + println!("{}", data.data); + } else { + println!("No message available yet."); + } + Ok(()) + } +} +fn main() -> Result<(), RclrsError> { + let context = Context::new(env::args()).unwrap(); + let subscription = Arc::new(SimpleSubscriptionNode::new(&context).unwrap()); + let subscription_other_thread = Arc::clone(&subscription); + thread::spawn(move || loop { + thread::sleep(Duration::from_millis(1000)); + subscription_other_thread.data_callback().unwrap() + }); + rclrs::spin(subscription.node.clone()) +} +``` +
Examining the code in detail: + +#### SimpleSubscriptionNode: +```rust +pub struct SimpleSubscriptionNode { + node: Arc, + _subscriber: Arc>, + data: Arc>>, +} +``` +Instead of a Publisher, there is a Subscription object in the Subscriber node. The data needs to be an `Arc>>` because there can be errors in the data transfer process and this can be caught by including the value of the incoming subscription in an optional. +#### impl SimpleSubscriptionNode +This code defines methods for the `SimpleSubscriptionNode` `struct`. + +##### new +The `new` method creates a ROS 2 node, subscriber, and a storage location for received messages, storing them in the `struct`. +```rust + fn new(context: &Context) -> Result { + let node = create_node(context, "simple_subscription").unwrap(); + let data: Arc>> = Arc::new(Mutex::new(None)); + let data_mut: Arc>> = Arc::clone(&data); + let _subscriber = node + .create_subscription::( + "publish_hello", + QOS_PROFILE_DEFAULT, + move |msg: StringMsg| { + *data_mut.lock().unwrap() = Some(msg); + }, + ) + .unwrap(); + Ok(Self { + node, + _subscriber, + data, + }) + } +``` +A few special features: +1. Initializing Shared Data: + * `let data: Arc>> = Arc::new(Mutex::new(None));` + This line creates a shared data structure that will hold the received message. + * `Arc>>`: This is a complex type combining several functionalities: + * `Arc`: An atomically reference-counted pointer ([`Arc`](https://doc.rust-lang.org/std/sync/struct.Arc.html)) allows multiple parts of the code to safely access the same data (`T`). + * `Mutex`: A mutual exclusion lock ([`Mutex`](https://doc.rust-lang.org/std/sync/struct.Mutex.html)) ensures only one thread can modify the data (`T`) at a time, preventing race conditions. + * `Option`: This represents an optional value that can either hold a message of type `StringMsg` or be `None` if no message has been received yet. + * `Arc::new(Mutex::new(None))`: This creates a new instance of `Arc>>` and initializes the inner `Mutex` with `None`. +2. Creating a Subscription: + * `let _subscriber = node.create_subscription::(...` + This line attempts to create a subscription using the created ROS node (`node`). + * `create_subscription`: This is creates a subscription to a specific topic. + * ``: This specifies the type of message the subscription is interested in (`StringMsg`) and a placeholder (`_`) for the callback [`closure`](https://doc.rust-lang.org/book/ch13-01-closures.html) type. + `"publish_hello"`: This is the name of the ROS topic this node wants to subscribe to. Messages of type `StringMsg` are expected on this topic. + * `move |msg: StringMsg| { ... }`: This is a closure ([anonymous function](https://en.wikipedia.org/wiki/Anonymous_function)) that will be called whenever a new message arrives on the subscribed topic. + * `msg: StringMsg`: This parameter receives the received message of type `StringMsg`. The closure body (`{...}`) uses the `Mutex` to access and update the shared data (`data_mut`) with the received message. +3. Cloning the Shared Data: + * `let data_mut: Arc>> = Arc::clone(&data)`; This line creates another `Arc` reference (`data_mut`) pointing to the same underlying data structure as data. This allows the closure to access and modify the shared data. +##### data_callback +This function provides a way to access and potentially use the received message data stored within the `data` member variable of the `SimpleSubscriptionNode`. It checks if a message exists, prints it if available, or informs the user there's no message yet. +```rust +fn data_callback(&self) -> Result<(), RclrsError> { + if let Some(data) = self.data.lock().unwrap().as_ref() { + println!("{}", data.data); + } else { + println!("No message available yet."); + } + Ok(()) +} + +``` +A few special features: +1. Checking for Received Message: + * `if let Some(data) = self.data.lock().unwrap().as_ref() { ... }`: This is an [`if-let`](https://doc.rust-lang.org/rust-by-example/flow_control/if_let.html) statement used for pattern matching on optional values. + * `self.data`: This accesses the member variable data of the `struct` (likely the `Arc>>` created earlier). + * `.lock().unwrap()`: This calls the lock method on the `Mutex` to gain exclusive access to the shared data. If another thread already holds the lock, lock might block until the lock is released. + `.as_ref()`: This converts the borrowed `MutexGuard` (returned by `.lock()`) into a reference to the inner value (`Option`). + * `Some(data)`: This pattern attempts to match the value inside the Option with `Some(data)`. If there's a message (`Some(data)`), the code block after the if is executed, and data is bound to the actual message content of type `StringMsg`. + +
+
+
Build and Run + +Once you have implemented the code, you are ready to make it runnable: +```sh +cd WORKSPACE +colcon build +``` +Please note that you'll need to run your nodes in separate terminals. In each terminal, you'll need to source your ROS 2 installation separately. So for each of the two nodes you've built so far, open a terminal and type the following: +```sh +cd WORKSPACE +source install/setup.bash +ros2 run rust_pubsub your_node_name +``` +In my case, the nodes are called `simple_publisher` and `simple_subscriber`. You can name your nodes whatever you like. It is important that the publisher and subscriber use the same topic type and name. +If you haven't had any errors so far and have successfully started the Publisher and Subscriber, you should see something similar in the Subscriber's Terminal window: +```sh +Hello World 230 +Hello World 231 +Hello World 232 +Hello World 233 +Hello World 234 +Hello World 235 +Hello World 236 +Hello World 237 +Hello World 238 +Hello World 239 +Hello World 240 +Hello World 241 +Hello World 242 +Hello World 243 +Hello World 244 +Hello World 245 +Hello World 246 +``` +(My nodes have been running for some time.) +Enter `Ctrl+c` in each terminal to stop the nodes from spinning. +
+
+ +
Summary + +You created two nodes to publish and subscribe to data over a topic. Before running them, you added their dependencies and entry points to the package configuration files. + +
+ +
Last thoughts + +At the end of the day, tools must not only work more safely and efficiently from a purely rational point of view, but they must also give the end user, as well as the developer, a good time. Hopefully you had fun developing the two nodes. Without fun, software development can be boring and will often prevent you from using this tool again. + +
diff --git a/examples/rust_pubsub/Cargo.toml b/examples/rust_pubsub/Cargo.toml new file mode 100644 index 000000000..487667556 --- /dev/null +++ b/examples/rust_pubsub/Cargo.toml @@ -0,0 +1,16 @@ +[package] +name = "rust_pubsub" +version = "0.1.0" +edition = "2021" + +[[bin]] +name="simple_publisher" +path="src/simple_publisher.rs" + +[[bin]] +name="simple_subscriber" +path="src/simple_subscriber.rs" + +[dependencies] +rclrs = "*" +std_msgs = "*" diff --git a/examples/rust_pubsub/package.xml b/examples/rust_pubsub/package.xml new file mode 100644 index 000000000..f988ccfa4 --- /dev/null +++ b/examples/rust_pubsub/package.xml @@ -0,0 +1,14 @@ + + rust_pubsub + 0.0.0 + TODO: Package description. + user + TODO: License declaration. + + rclrs + std_msgs + + + ament_cargo + + diff --git a/examples/rust_pubsub/src/simple_publisher.rs b/examples/rust_pubsub/src/simple_publisher.rs new file mode 100644 index 000000000..98d0e0f74 --- /dev/null +++ b/examples/rust_pubsub/src/simple_publisher.rs @@ -0,0 +1,36 @@ +use rclrs::{create_node, Context, Node, Publisher, RclrsError, QOS_PROFILE_DEFAULT}; +use std::{sync::Arc, thread, time::Duration}; +use std_msgs::msg::String as StringMsg; +struct SimplePublisherNode { + node: Arc, + _publisher: Arc>, +} +impl SimplePublisherNode { + fn new(context: &Context) -> Result { + let node = create_node(context, "simple_publisher").unwrap(); + let _publisher = node + .create_publisher("publish_hello", QOS_PROFILE_DEFAULT) + .unwrap(); + Ok(Self { node, _publisher }) + } + + fn publish_data(&self, increment: i32) -> Result { + let msg: StringMsg = StringMsg { + data: format!("Hello World {}", increment), + }; + self._publisher.publish(msg).unwrap(); + Ok(increment + 1_i32) + } +} + +fn main() -> Result<(), RclrsError> { + let context = Context::new(std::env::args()).unwrap(); + let publisher = Arc::new(SimplePublisherNode::new(&context).unwrap()); + let publisher_other_thread = Arc::clone(&publisher); + let mut count: i32 = 0; + thread::spawn(move || loop { + thread::sleep(Duration::from_millis(1000)); + count = publisher_other_thread.publish_data(count).unwrap(); + }); + rclrs::spin(publisher.node.clone()) +} diff --git a/examples/rust_pubsub/src/simple_subscriber.rs b/examples/rust_pubsub/src/simple_subscriber.rs new file mode 100644 index 000000000..a0d02bb4c --- /dev/null +++ b/examples/rust_pubsub/src/simple_subscriber.rs @@ -0,0 +1,52 @@ +use rclrs::{create_node, Context, Node, RclrsError, Subscription, QOS_PROFILE_DEFAULT}; +use std::{ + env, + sync::{Arc, Mutex}, + thread, + time::Duration, +}; +use std_msgs::msg::String as StringMsg; +pub struct SimpleSubscriptionNode { + node: Arc, + _subscriber: Arc>, + data: Arc>>, +} +impl SimpleSubscriptionNode { + fn new(context: &Context) -> Result { + let node = create_node(context, "simple_subscription").unwrap(); + let data: Arc>> = Arc::new(Mutex::new(None)); + let data_mut: Arc>> = Arc::clone(&data); + let _subscriber = node + .create_subscription::( + "publish_hello", + QOS_PROFILE_DEFAULT, + move |msg: StringMsg| { + *data_mut.lock().unwrap() = Some(msg); + }, + ) + .unwrap(); + Ok(Self { + node, + _subscriber, + data, + }) + } + fn data_callback(&self) -> Result<(), RclrsError> { + if let Some(data) = self.data.lock().unwrap().as_ref() { + println!("{}", data.data); + } else { + println!("No message available yet."); + } + Ok(()) + } +} +fn main() -> Result<(), RclrsError> { + let context = Context::new(env::args()).unwrap(); + let subscription = Arc::new(SimpleSubscriptionNode::new(&context).unwrap()); + let subscription_other_thread = Arc::clone(&subscription); + thread::spawn(move || loop { + thread::sleep(Duration::from_millis(1000)); + subscription_other_thread.data_callback().unwrap() + }); + rclrs::spin(subscription.node.clone()) +} diff --git a/rclrs/src/parameter/service.rs b/rclrs/src/parameter/service.rs index a52e3e555..7c8ffe62d 100644 --- a/rclrs/src/parameter/service.rs +++ b/rclrs/src/parameter/service.rs @@ -123,11 +123,11 @@ fn get_parameters(req: GetParameters_Request, map: &ParameterMap) -> GetParamete } fn list_parameters(req: ListParameters_Request, map: &ParameterMap) -> ListParameters_Response { - let check_parameter_name_depth = |substring: &[i8]| { + let check_parameter_name_depth = |substring: &[std::os::raw::c_char]| { if req.depth == ListParameters_Request::DEPTH_RECURSIVE { return true; } - u64::try_from(substring.iter().filter(|c| **c == ('.' as i8)).count()).unwrap() < req.depth + u64::try_from(substring.iter().filter(|c| **c == ('.' as _)).count()).unwrap() < req.depth }; let names: Sequence<_> = map .storage diff --git a/rosidl_runtime_rs/src/sequence.rs b/rosidl_runtime_rs/src/sequence.rs index 588e14fc2..855afd294 100644 --- a/rosidl_runtime_rs/src/sequence.rs +++ b/rosidl_runtime_rs/src/sequence.rs @@ -309,18 +309,26 @@ where /// /// Equivalent to `&seq[..]`. pub fn as_slice(&self) -> &[T] { - // SAFETY: self.data points to self.size consecutive, initialized elements and - // isn't modified externally. - unsafe { std::slice::from_raw_parts(self.data, self.size) } + if self.data.is_null() { + &[] + } else { + // SAFETY: self.data is not null and points to self.size consecutive, + // initialized elements and isn't modified externally. + unsafe { std::slice::from_raw_parts(self.data, self.size) } + } } /// Extracts a mutable slice containing the entire sequence. /// /// Equivalent to `&mut seq[..]`. pub fn as_mut_slice(&mut self) -> &mut [T] { - // SAFETY: self.data points to self.size consecutive, initialized elements and - // isn't modified externally. - unsafe { std::slice::from_raw_parts_mut(self.data, self.size) } + if self.data.is_null() { + &mut [] + } else { + // SAFETY: self.data is not null and points to self.size consecutive, + // initialized elements and isn't modified externally. + unsafe { std::slice::from_raw_parts_mut(self.data, self.size) } + } } } @@ -602,8 +610,10 @@ macro_rules! impl_sequence_alloc_for_primitive_type { unsafe { // This allocates space and sets seq.size and seq.capacity to size let ret = $init_func(seq as *mut _, size); - // Zero memory, since it will be uninitialized if there is no default value - std::ptr::write_bytes(seq.data, 0u8, size); + if !seq.data.is_null() { + // Zero memory, since it will be uninitialized if there is no default value + std::ptr::write_bytes(seq.data, 0u8, size); + } ret } } @@ -783,6 +793,12 @@ mod tests { } } + #[test] + fn test_empty_sequence() { + assert!(Sequence::::default().is_empty()); + assert!(BoundedSequence::::default().is_empty()); + } + quickcheck! { fn test_extend(xs: Vec, ys: Vec) -> bool { let mut xs_seq = Sequence::new(xs.len());