Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undergo ros/rosdistro review procedure before requesting release repository #106

Open
ijnek opened this issue Aug 24, 2022 · 0 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@ijnek
Copy link
Member

ijnek commented Aug 24, 2022

In #99, there's been some discussion about undergoing ros/rosdistro review procedure before requesting a release repository here on ros2-gbp. I'm going to move this to a dedicated issue so we can discuss further. Quoting the important parts:

The reason I'm pushing for brand-new repositories to be registered in the rosdistro index prior to provisioning their release repositories here is that I'd like the packages to undergo the review procedures we have in place in ros/rosdistro. Not the least of which is the package naming review, which could result in more work here if the name changes. (@cottsay)

A bloom release doesn't have to be the first interaction with the rosdistro database.
There are three stanzas under a repository listing in rosdistro: doc, source, and release. Bloom will offer to create all of them if none exist yet but it's also entirely possible to add source and/or doc entries beforehand, especially for projects in early development.

I can't say definitively but in the days before free CI (Travis, Circle, GitHub Actions, etc) was available I think it was more common for package maintainers to add source entries before the initial release is made in order to make use of devel jobs for their projects' primary CI. (@nuclearsandwich)

We've talked about this once or twice and I agree with the rationale but keep forgetting to put it on the official agenda for discussion in the ROS 2 team and open the review guidelines update PR. (@nuclearsandwich)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

No branches or pull requests

2 participants