Cannot pull private submodules using ssh

[sallydly]

Description

When a private submodule's url is ssh (git@github.com:), the action is unable to pull the repository because it expects it to be an https url before it replaces it with a URL using the PAT.

Expected Behavior

Private submodule should be pulled regardless if the url is https or ssh.

Actual Behavior

Failure to clone private submodule

To Reproduce

1. In .gitmodules, include a private submodule with an ssh url.
2. Run action.
3. Action will be unable to pull private submodule.

System (please complete the following information)

• OS: Ubuntu 20.04
• ROS 2 Distro: Foxy

[christophebedard]

Hi, thanks for bringing this up! As you mentioned, using a PAT is the only working solution right now. I think the way action-ros-ci imports private repositories definitely needs to be improved. See also #765.

One solution might be to just rely on actions/checkout instead of changing the git config, but it would require changing the way action-ros-ci works internally (see #765 (comment)). Contributions for this are of course welcome.