Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatch between build_and_test vs linter_cpplint #58

Open
Karsten1987 opened this issue Jan 13, 2020 · 5 comments
Open

mismatch between build_and_test vs linter_cpplint #58

Karsten1987 opened this issue Jan 13, 2020 · 5 comments
Labels
bug Something isn't working question Further information is requested

Comments

@Karsten1987
Copy link

When looking at the checks currently applied at rosbag2 I see some mismatch which I can't really explain.

For example in this PR: ros2/rosbag2#225

I see that build_and_test fails with cpplint and uncrustify not being happy:

  [6.446s] The following tests FAILED:
  [6.446s] 	  5 - cpplint (Failed)
  [6.446s] 	  7 - uncrustify (Failed)

However, the dedicated checks (uncrustify and cpplint) are returning successful. How should I interpret this?

@Karsten1987 Karsten1987 added the question Further information is requested label Jan 13, 2020
@zmichaels11
Copy link
Contributor

@thomas-moulard please take a look at this

@thomas-moulard
Copy link
Member

thomas-moulard commented Jan 13, 2020

@Karsten1987 Could you link the logs? The latest CI builds have the linters happy.

2020-01-13T10:43:55.7535073Z [8.974s] 100% tests passed, 0 tests failed out of 9
2020-01-13T10:43:55.7535176Z [8.974s] 
2020-01-13T10:43:55.7535273Z [8.974s] Label Time Summary:
2020-01-13T10:43:55.7535363Z [8.975s] copyright     =   0.58 sec*proc (1 test)
2020-01-13T10:43:55.7535468Z [8.975s] cppcheck      =   0.64 sec*proc (1 test)
2020-01-13T10:43:55.7535747Z [8.975s] cpplint       =   0.79 sec*proc (1 test)
2020-01-13T10:43:55.7535842Z [8.975s] gmock         =   4.72 sec*proc (3 tests)
2020-01-13T10:43:55.7535925Z [8.975s] lint_cmake    =   0.56 sec*proc (1 test)
2020-01-13T10:43:55.7536024Z [8.975s] linter        =   3.85 sec*proc (6 tests)
2020-01-13T10:43:55.7536125Z [8.975s] uncrustify    =   0.65 sec*proc (1 test)
2020-01-13T10:43:55.7537582Z [8.975s] xmllint       =   0.64 sec*proc (1 test)

The linters are installed from eloquent vs the one in the CI are from master. That may be the issue? I was hopeful that the linters would stay reasonably in sync, but this may have been an incorrect assumption :/

If this is why we see this, one way to fix the issue would be to use a Docker image embedding e.g. a nightly snapshot of ROS2 master.

@Karsten1987
Copy link
Author

wich logs would you like to see? I am just looking at the detailed output of the checks running in the previously linked PR.

https://github.com/ros2/rosbag2/pull/225/checks?check_run_id=386643854
vs
https://github.com/ros2/rosbag2/pull/225/checks?check_run_id=386643930

@thomas-moulard
Copy link
Member

@Karsten1987 I saw your comment in the other thread - FYI build_and_test is equivalent to what ci.ros2.org is doing, so those two should always be in sync.

The lint jobs are installing eloquent packages, that's why they may not be completely in sync.

@thomas-moulard thomas-moulard added the bug Something isn't working label Jan 15, 2020
@emersonknapp
Copy link
Contributor

This may be related to #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants