Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcov code breaks build on Mac, Windows #312

Open
rotu opened this issue Aug 20, 2020 · 2 comments
Open

lcov code breaks build on Mac, Windows #312

rotu opened this issue Aug 20, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@rotu
Copy link
Contributor

rotu commented Aug 20, 2020

Description

The build is failing for cyclonedds and other packages on Mac and Windows due to missing lcov.

Expected Behavior

The build should not break. Either lcov should not be run by default or in its absence, the build should not fail.

Actual Behavior

https://github.com/ros2/rmw_cyclonedds/runs/985853020#step:5:5529
https://github.com/ros2/rmw_cyclonedds/runs/985853090#step:5:5343

To Reproduce

https://github.com/ros2/rmw_cyclonedds/actions/runs/208880070/workflow

System (please complete the following information)

  • OS: macOS-latest, windows-latest
  • ROS 2 Distro: rolling

Additional context

It looks like some attempt was made for this error not to be fatal by passing an ignoreReturnCode option. Unfortunately, this doesn't appear to work as intended.

await execBashCommand(colconLcovInitialCmd, colconCommandPrefix, {
cwd: rosWorkspaceDir,
ignoreReturnCode: true,
});

await execBashCommand(colconLcovResultCmd, colconCommandPrefix, {
cwd: rosWorkspaceDir,
ignoreReturnCode: true,
});

@rotu rotu added the bug Something isn't working label Aug 20, 2020
@rotu
Copy link
Contributor Author

rotu commented Aug 20, 2020

@thomas-moulard could you please take a look at this? I'm having trouble even getting coverage working on Linux, so I'm not sure if I'm doing it right.

https://github.com/RoverRobotics-forks/rmw_cyclonedds/blob/bb42980bc54e5623c62695d5e805a0d9e18d83df/.github/workflows/CI.yml#L31-L57

@emersonknapp emersonknapp added bug Something isn't working and removed bug Something isn't working labels Nov 6, 2020
@christophebedard
Copy link
Member

Just as a note, #712 disabled colcon-lcov-result on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants