Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not obvious how to correctly build from source #120

Closed
2 tasks
rotu opened this issue Mar 30, 2020 · 3 comments
Closed
2 tasks

Not obvious how to correctly build from source #120

rotu opened this issue Mar 30, 2020 · 3 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@rotu
Copy link
Contributor

rotu commented Mar 30, 2020

Description

Fails to build with Ubuntu 18.04 and ROS source (i.e. master).

Note that all other platform/district pairs appear to build.

matrix:
  os: [ubuntu-18.04, macOS-latest, windows-latest]
  rosdistro: [dashing, eloquent, source]

https://github.com/RoverRobotics-forks/rmw_cyclonedds/pull/1/checks?check_run_id=544943756

Exit Criteria

  • All inputs of the action are validated and properly throw an error if the input parameter is invalid
  • Clarify the documentation to explain that by default, action-ros-ci is building from source because the default VCS file is containing all the ROS 2 repositories.
@rotu rotu added the bug Something isn't working label Mar 30, 2020
@thomas-moulard
Copy link
Member

source is not a valid value for required-ros-distributions for action setup-ros.

There is a bug in the doc in https://github.com/ros-tooling/setup-ros/blob/master/action.yml
An empty string should be passed instead.

@rotu
Copy link
Contributor Author

rotu commented Mar 30, 2020

Thanks! That's exactly why I made this mistake. Here are some other suggestions which could help in addition to updating the docs:

  1. required-ros-distributions doesn't really tell me that it's binaries. Maybe rename to 'binary-ros-distributions`.
  2. I expect the failure message to mention that the provided value is invalid.
  3. I expect the Mac OS and Windows to also fail if given an invalid distribution. I see that this argument is ignored silently on those platforms, but it should issue a warning or an error.

@rotu rotu changed the title Ubuntu / source build broken Not obvious how to correctly build from source Mar 30, 2020
@emersonknapp emersonknapp added the documentation Improvements or additions to documentation label Apr 10, 2020
@prajakta-gokhale prajakta-gokhale added this to the Sprint #19 milestone May 8, 2020
@prajakta-gokhale prajakta-gokhale assigned mm318 and jikawa-az and unassigned mm318 May 11, 2020
@prajakta-gokhale prajakta-gokhale removed this from the Sprint #19 milestone May 22, 2020
@zmichaels11 zmichaels11 added this to the Sprint #21 milestone Jun 5, 2020
@jikawa-az
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

7 participants