Skip to content

Commit 634499e

Browse files
Update CI platforms and depenencies.
Use extras_require.test to install test dependencies. Following the convention established by ROS infrastructure packages I've left coverage out of the required test dependencies so it is still installed explicitly for the GitHub action. Add extras_require.test and pin flake8 < 5. flake8 5 removes the API being used for configuration. It's unclear to me as of yet whether it is possible to make this setup work for both Flake8 <5 and Flake8 5. The ROS infra team has not tackled this yet. In the meantime, let's try to get the workflow going again using flake8 4. Also removes the variable indirection for installs_require since it isn't used to do anything at the moment. Quote all python versions in yaml. Python 3.1 != Python 3.10 Update python versions tested in CI.
1 parent daf3893 commit 634499e

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,14 @@ jobs:
1212
strategy:
1313
matrix:
1414
os: [ubuntu-latest]
15-
python-version: [3.5, 3.6, 3.7, 3.8]
15+
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"]
1616
include:
1717
- os: macos-latest
18-
python-version: 3.8
18+
python-version: "3.10"
1919
- os: windows-latest
20-
python-version: 3.8
20+
python-version: "3.8"
21+
- os: windows-latest
22+
python-version: "3.10"
2123

2224
steps:
2325
- uses: actions/checkout@v2
@@ -35,7 +37,8 @@ jobs:
3537
if: matrix.os == 'macos-latest'
3638
- name: Test with pytest
3739
run: |
38-
pip install --upgrade coverage flake8 flake8-docstrings flake8-import-order pytest
40+
pip install --upgrade .[test]
41+
pip install --upgrade coverage
3942
git config --global --add init.defaultBranch master
4043
git config --global --add advice.detachedHead true
4144
${{ matrix.os == 'windows-latest' && 'set PYTHONPATH=%cd% &&' || 'PYTHONPATH=`pwd`' }} pytest -s -v test

setup.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,21 @@
22
from setuptools import setup
33
from vcstool import __version__
44

5-
install_requires = ['PyYAML', 'setuptools']
6-
75
setup(
86
name='vcstool',
97
version=__version__,
10-
install_requires=install_requires,
8+
install_requires=[
9+
'PyYAML',
10+
'setuptools'],
11+
extras_require={
12+
'test': [
13+
'flake8 >= 3.7, < 5',
14+
'flake8-docstrings',
15+
'flake8-import-order',
16+
'pycodestyle < 2.9.0',
17+
'pyflakes < 2.5.0',
18+
'pytest']
19+
},
1120
packages=find_packages(),
1221
author='Dirk Thomas',
1322
author_email='web@dirk-thomas.net',

0 commit comments

Comments
 (0)