fix "ros2 invalid choice: 'launch'" by rosdep install #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
christophfroehlich,
DasRoteSkelett,
destogl,
homalozoa,
jaron-l and
VanshGehlot
|
humble had the same issue. Do i make a seperate pr for that or is there some github magic I'm not aware of? |
bijoua29
approved these changes
Jun 1, 2023
Normally, we trigger a backport manually after it is merged to the master branch. |
christophfroehlich
approved these changes
Jun 1, 2023
|
@Mergifyio backport humble |
|
ye I'm working on the docker file and it was saying ros2 doesn't have a launch command my brain went ?????? |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
(cherry picked from commit eb60429)
christophfroehlich
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to add dockerfiles for this repo it was throwing this:
Solution inspired by:
https://github.com/ros-controls/gz_ros2_control/blob/master/gz_ros2_control_demos/package.xml#L36
the other launch deps are not needed since they are already listed for ros2launch.