Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test-URDF from transmission interface to ros2_control_test_assets #648

Open
destogl opened this issue Feb 16, 2022 · 0 comments
Open

Comments

@destogl
Copy link
Member

destogl commented Feb 16, 2022

I propose to extend the minimal robot from the ros2_control_test_assets with transmission tags too. This should be then used for testing of transmissions.

The idea is to have one fully-featured URDF for doing main test of different features. Although not all tags will be used in all tests, they all have to be parsable and should not collide with each other. This can be only achieved if we really use the same test-URDF in most cases. Moreover, this reduces code duplication and potential issues is URDF get updated anytime in the future.

Original comment:

Why not to add this into ros2_control_test_assets? It would be a better and reusable place for this. Maybe there is already exactly the one you need. Or perhaps we can only extend the existing MinimalRobot with this.

Originally posted by @destogl in #633 (comment)

@destogl destogl changed the title Move test-URDF from transmission interface to ros2_control_test_assets? It would be a better and reusable place for this. Maybe there is already exactly the one you need. Or perhaps we can only extend the existing MinimalRobot with thi Move test-URDF from transmission interface to ros2_control_test_assets Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant