Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realtime_tools API restructure #81

Open
bmagyar opened this issue Feb 25, 2022 · 1 comment
Open

realtime_tools API restructure #81

bmagyar opened this issue Feb 25, 2022 · 1 comment
Assignees

Comments

@bmagyar
Copy link
Member

bmagyar commented Feb 25, 2022

The ROS2 realtime_tools API is a little clunky, requiring the user to still define the publisher on their side instead of incorporating it into the realtime publisher.

This makes for a fairly defunct API where we don't gain much code reduction but there's still an increase in complexity and dependencies.

Rework the realtime_tools RealtimePublisher API such that it is as lean as possible to use.

@YoavFekete
Copy link
Contributor

YoavFekete commented Aug 17, 2022

Hi so i did it implemented new contactor for RealtimePublisher that creates the publisher inside the contactor .
i did it on top of a new branch that fixes #85 and #82 , so lets finish that pull request and then ill create a new pull request for the API rework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants