-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Support data in v2" #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0d95143.
lizkrznarich
approved these changes
Feb 20, 2024
kaysiz
added a commit
that referenced
this pull request
Apr 2, 2024
* Support data in v2 (#194) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Revert "Support data in v2 (#194)" (#199) This reverts commit 0d95143. * Support for schema v2 (#198) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Revert "Support for schema v2 (#198)" (#200) This reverts commit eef6b0a. * Support for schema v2 (#201) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Show or hide othernames based on content * remove () from relationships
kaysiz
added a commit
that referenced
this pull request
Apr 2, 2024
* Support data in v2 (#194) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Revert "Support data in v2 (#194)" (#199) This reverts commit 0d95143. * Support for schema v2 (#198) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Revert "Support for schema v2 (#198)" (#200) This reverts commit eef6b0a. * Support for schema v2 (#201) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Show or hide othernames based on content * remove () from relationships
kaysiz
added a commit
that referenced
this pull request
Apr 12, 2024
* Update dependabot.yml * Update UI to support V2 API (#204) (#205) * Support data in v2 (#194) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Revert "Support data in v2 (#194)" (#199) This reverts commit 0d95143. * Support for schema v2 (#198) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Revert "Support for schema v2 (#198)" (#200) This reverts commit eef6b0a. * Support for schema v2 (#201) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Show or hide othernames based on content * remove () from relationships * Add lang to all otherNames * Handle api urls for different envs for the json schema url --------- Co-authored-by: Liz Krznarich <liz.krznarich@datacite.org>
kaysiz
added a commit
that referenced
this pull request
Apr 12, 2024
* Update dependabot.yml * Update UI to support V2 API (#204) (#205) * Support data in v2 (#194) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Revert "Support data in v2 (#194)" (#199) This reverts commit 0d95143. * Support for schema v2 (#198) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Revert "Support for schema v2 (#198)" (#200) This reverts commit eef6b0a. * Support for schema v2 (#201) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Show or hide othernames based on content * remove () from relationships * Add lang to all otherNames * Handle api urls for different envs for the json schema url * Fix build eror --------- Co-authored-by: Liz Krznarich <liz.krznarich@datacite.org>
kaysiz
added a commit
that referenced
this pull request
Apr 12, 2024
* Update dependabot.yml * Update UI to support V2 API (#204) (#205) * Support data in v2 (#194) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Revert "Support data in v2 (#194)" (#199) This reverts commit 0d95143. * Support for schema v2 (#198) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Revert "Support for schema v2 (#198)" (#200) This reverts commit eef6b0a. * Support for schema v2 (#201) * Add launch darkly addon * Add slient side key to envs * Configure launch darkly * setup UI versioning * setup variation for api urll v1 and v2 * Handle types, v2 returns lowecase value * Add versioning to components * Update model for name to names * WIP: update template with new data * Set name correctly * Implement v2 view templates for v2, fix model to work with v2 * Update launch darkly with correct client side id for env * removing key for anonymous user mode * Update config to use remote flags * Update the adapters to use remote flags * Update the route to use remote flags * Update the templates to use remote flags * Fix bug with website fixes #218 * Fix other names display issue * comma separate org types * Update text for submitting a change request * fix duplicate lang on othernames * Show or hide othernames based on content * remove () from relationships * Add lang to all otherNames * Handle api urls for different envs for the json schema url * Fix build eror * Fix build error --------- Co-authored-by: Liz Krznarich <liz.krznarich@datacite.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #194