Skip to content
This repository has been archived by the owner on Sep 3, 2020. It is now read-only.

Installation is not idempotent #3

Open
dzubchik opened this issue Dec 20, 2017 · 6 comments
Open

Installation is not idempotent #3

dzubchik opened this issue Dec 20, 2017 · 6 comments

Comments

@dzubchik
Copy link

Each run creates new vault keys. I propose to add option to regenerate them, but remove this as default behavior.

@roquie
Copy link
Owner

roquie commented Dec 20, 2017

Okay. I think It to be possible if add the following condition (2 times):

when: ks_vault_key|default('')|length == 0 and ks_vault_generate

@roquie
Copy link
Owner

roquie commented Dec 20, 2017

It's normal solution for you?

@dzubchik
Copy link
Author

dzubchik commented Dec 20, 2017

Looks good to me. And would be nice to have the test for this, because it's very dangerous option.

@roquie
Copy link
Owner

roquie commented Dec 22, 2017

look this pls #4

@dzubchik
Copy link
Author

Thanks, I will look closely this PR before Monday.

@dzubchik
Copy link
Author

Yes, it solves current issue. During testing I realized that here are a larger issue with installation process. I will send PR for it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants