Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyedit 1-4 #102

Merged
merged 9 commits into from
Jun 7, 2022
Merged

copyedit 1-4 #102

merged 9 commits into from
Jun 7, 2022

Conversation

jonthegeek
Copy link
Contributor

As I read I can't help but copyedit. I hope you find these helpful!

As I read I can't help but copyedit. I hope you find these helpful!
@jonthegeek jonthegeek marked this pull request as draft June 4, 2022 23:41
There was a loose standard to only use the `{package}` format the first time it was introduced, but then chapter 4 mixed that up. In the previous commits I systematically enforced that rule. Here I always format them. I like this way better, but I can roll back this commit if you prefer the other way.
@jonthegeek jonthegeek marked this pull request as ready for review June 5, 2022 00:05
jonthegeek and others added 6 commits June 5, 2022 09:59
I finally rebuilt and saw that the special formatting becomes links, so we definitely don't want the special formatting inside of links.
@maelle
Copy link
Member

maelle commented Jun 7, 2022

This is most useful, thanks a ton! I added your name to index.Rmd. Thanks again!!

@maelle maelle merged commit 08c4b9d into ropensci-books:main Jun 7, 2022
@jonthegeek jonthegeek deleted the typos branch June 11, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants