fix gist_create to look for possible scopes problem in auth fix #70

sckott · sckott · commit 54a5cbad19ba · 2018-06-27T14:04:35.000-07:00
diff --git a/R/gist_create.R b/R/gist_create.R
@@ -24,15 +24,6 @@
 #' numbers
 #' '})
 #'
-#' # or include results if you want, and change the filename in this case
-#' gist_create(code={'
-#' x <- letters
-#' numbers <- runif(8)
-#' numbers
-#'
-#' [1] 0.3229318 0.5933054 0.7778408 0.3898947 0.1309717 0.7501378 0.3206379 0.3379005
-#' '}, filename="my_cool_code.R")
-#'
 #' # Knit an .Rmd file before posting as a gist
 #' file <- system.file("examples", "stuff.Rmd", package = "gistr")
 #' gist_create(file, description='a new cool gist', knit=TRUE)
@@ -54,11 +45,10 @@
 #' '}, knit=TRUE)
 #'
 #' library('httr')
-#' base <- "http://pelias.mapzen.com/search"
-#' res <- httr::GET(base, query = list(input = 'coffee shop', lat = 45.5, 
-#' lon = -122.6))
+#' url <- "https://github.com/ropensci/geojsonio/blob/master/inst/examples/zillow_or.geojson"
+#' res <- httr::GET(url)
 #' json <- httr::content(res, as = "text")
-#' gist_create(code = json, filename = "pelias_test.geojson")
+#' gist_create(code = json, filename = "zillow_or.geojson")
 #'
 #' # Knit and include source file, so both files are in the gist
 #' file <- system.file("examples", "stuff.Rmd", package = "gistr")
@@ -77,8 +67,7 @@
 #' cat(readLines(file), sep = "\n") # peek at file
 #' gist_create(file, knit=TRUE)
 #' ## if not, GitHub doesn't allow upload of binary files via the HTTP API 
-#' ## (which gistr uses) but check back later as I'm working on an option to 
-#' ## get binary files uploaded, but will involve having to use git
+#' ## (which gistr uses) - so see gist_create_git(), which uses git
 #' file <- system.file("examples", "plots.Rmd", package = "gistr")
 #' gist_create(file, knit=TRUE, imgur_inject = TRUE)
 #' ## works with ggplot2 as well
diff --git a/R/zzz.R b/R/zzz.R
@@ -106,7 +106,12 @@ stopstatus <- function(x) {
                                             encoding = "UTF-8"), FALSE)
     errs <- sapply(res$errors, function(z) paste(names(z), z, sep = ": ", 
                                                  collapse = "\n"))
-    stop(res$message, "\n", errs, call. = FALSE)
+    # check for possible oauth scope problems
+    scopes_problem <- ""
+    if (is.null(x$`x-oauth-scopes`)) {
+      scopes_problem <- "  GitHub response headers suggest no or insufficient scopes\n  To create gists you need the `gist` OAuth scope on your token."
+    }
+    stop(res$message, "\n", errs, "\n", scopes_problem, call. = FALSE)
   }
 }
 
diff --git a/inst/examples/example1.md b/inst/examples/example1.md
@@ -7,4 +7,4 @@ And I shall summarize them.
     summary(x)
 
     ##     Min.  1st Qu.   Median     Mean  3rd Qu.     Max. 
-    ## -3.73500 -0.70820 -0.03440 -0.05312  0.66780  3.22000
+    ## -2.83791 -0.65021  0.06139  0.01810  0.67508  3.02495
diff --git a/inst/examples/plots.md b/inst/examples/plots.md
@@ -7,7 +7,7 @@
 plot(mpg ~ cyl, data=mtcars)
 ```
 
-![plot of chunk unnamed-chunk-2](http://i.imgur.com/Xs5LxrB.png)
+![plot of chunk unnamed-chunk-2](https://i.imgur.com/UVoPCi3.png)
 
 ## Bar plot
 
@@ -16,7 +16,7 @@ plot(mpg ~ cyl, data=mtcars)
 barplot(VADeaths)
 ```
 
-![plot of chunk unnamed-chunk-3](http://i.imgur.com/r2AzPmZ.png)
+![plot of chunk unnamed-chunk-3](https://i.imgur.com/13Re4qX.png)
 
 ## Histogram
 
@@ -25,4 +25,4 @@ barplot(VADeaths)
 hist(iris$Petal.Length)
 ```
 
-![plot of chunk unnamed-chunk-4](http://i.imgur.com/IyZzKVb.png)
+![plot of chunk unnamed-chunk-4](https://i.imgur.com/EItnHcZ.png)
diff --git a/inst/examples/plots_imgur.md b/inst/examples/plots_imgur.md
@@ -7,7 +7,7 @@
 plot(mpg ~ cyl, data=mtcars)
 ```
 
-![plot of chunk unnamed-chunk-2](http://i.imgur.com/fs0ReVy.png)
+![plot of chunk unnamed-chunk-2](https://i.imgur.com/giiuYcd.png)
 
 ## Bar plot
 
@@ -16,7 +16,7 @@ plot(mpg ~ cyl, data=mtcars)
 barplot(VADeaths)
 ```
 
-![plot of chunk unnamed-chunk-3](http://i.imgur.com/2hTWmZW.png)
+![plot of chunk unnamed-chunk-3](https://i.imgur.com/jL7cJJb.png)
 
 ## Histogram
 
@@ -25,4 +25,4 @@ barplot(VADeaths)
 hist(iris$Petal.Length)
 ```
 
-![plot of chunk unnamed-chunk-4](http://i.imgur.com/VYADPOf.png)
+![plot of chunk unnamed-chunk-4](https://i.imgur.com/OcymFMa.png)
diff --git a/inst/examples/rmarkdown_eg.md b/inst/examples/rmarkdown_eg.md
@@ -20,7 +20,7 @@ ggplot(mtcars, aes(cyl, hp)) +
   theme_grey(base_size = 18)
 ```
 
-![plot of chunk unnamed-chunk-3](http://i.imgur.com/SeIaFEQ.png)
+![plot of chunk unnamed-chunk-3](https://i.imgur.com/qhAguQK.png)
 
 ## Bar plot
 
@@ -31,4 +31,4 @@ ggplot(iris, aes(Species, Sepal.Length)) +
   theme_grey(base_size = 18)
 ```
 
-![plot of chunk unnamed-chunk-4](http://i.imgur.com/Di7yeGJ.png)
+![plot of chunk unnamed-chunk-4](https://i.imgur.com/byOPWhp.png)
diff --git a/man/gist_create.Rd b/man/gist_create.Rd

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,12 @@ stopstatus <- function(x) {`
`106`	`106`	`encoding = "UTF-8"), FALSE)`
`107`	`107`	`errs <- sapply(res$errors, function(z) paste(names(z), z, sep = ": ",`
`108`	`108`	`collapse = "\n"))`
`109`		`- stop(res$message, "\n", errs, call. = FALSE)`
	`109`	`+ # check for possible oauth scope problems`
	`110`	`+ scopes_problem <- ""`
	`111`	+ if (is.null(x$`x-oauth-scopes`)) {
	`112`	+ scopes_problem <- " GitHub response headers suggest no or insufficient scopes\n To create gists you need the `gist` OAuth scope on your token."
	`113`	`+ }`
	`114`	`+ stop(res$message, "\n", errs, "\n", scopes_problem, call. = FALSE)`
`110`	`115`	`}`
`111`	`116`	`}`
`112`	`117`