Fix migration constraints #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermoap
requested review from
JoDaBaRo,
mwolman and
santiagodiaz
as code owners
guillermoap
commented
Nov 10, 2023
| class_option :uuid, | ||
| type: :boolean, | ||
| default: false, | ||
| desc: 'Use UUID to identify aggregate records in events. Defaults to ID' |
There was a problem hiding this comment.
Open to suggestion on this wording and naming
santib
reviewed
Nov 10, 2023
santib
reviewed
Nov 10, 2023
santib
approved these changes
Nov 10, 2023
Generator has an option to set which type of identifier we want for our Outbox records.
…key on the aggregate_identifier - Created new testing models, one pair with IDs and another pair with UUIDs. - Updated spec to use shared_examples so it a little bit more DRY - Used modular testing config to be able to specify different classes and test that funcionality
guillermoap
force-pushed
the
fix-migration-constraints
branch
from
6bbe53a
to
475863a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that when the records where using IDs as the primary_key, when generating the outbox record it would fail because the migration specified that field to be UUID.
Not sure if this should be a minor version bump to 0.2.0. Open to suggestions.