create profile component #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahdinosaur
commented
Jun 20, 2017
•
ahdinosaur
commented
- app.TextField component and story
- app.TextAreaField component and story
- app.ImageField component and story
- use https://github.com/mosch/react-avatar-editor
- add file input (to click and pick file)
- test drag and drop file works
- add zoom slider
- store image data in form state
- agents.Profile component and story
- agents.Profile editing and display modes
- agents.ProfileIcon component and story
ahdinosaur
commented
Jun 21, 2017
agents/components/Avatar.js
Outdated
| @@ -16,7 +16,7 @@ function Avatar (props) { | |||
| const { | |||
| size, | |||
| styles, | |||
| agent: { profile: { name, image } } | |||
| image | |||
There was a problem hiding this comment.
hmm... i'm not sure how i feel about this change.
my thinking was that the components we are building are not strictly generic, they are re-usable but specific to the data model concepts in Cobuy. so since an "agent" is a first class data model concept, maybe we should build our components to accept them as arguments directly, to avoid all sorts of destructuring and restructuring code. or, what if we want to later include the agent name when the avatar is large. or put a star icon in the avatar if they are the admin of the current group.
but maybe i'm being silly.
There was a problem hiding this comment.
yeah, i had some questions around levels here - let's discuss after lunch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.