Skip to content

Commit 08dc2f2

Browse files
committed
CI: rewrite links to yet-to-be-uploaded PR artifacts to local. Just use @1.
1 parent 424375e commit 08dc2f2

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/continuous-integration-workflow.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
JEKYLL_ENV: production
3939

4040
- name: Check validity of links
41-
uses: lycheeverse/lychee-action@v1.8.0
41+
uses: lycheeverse/lychee-action@v1
4242
with:
4343
# Reasons for exclude
4444
# - https://root.cern/[0-9]+: Breaks checking local builds due to links in the metadata
@@ -50,10 +50,11 @@ jobs:
5050
# - nbviewer: When notebook generation fails, nbviewer returns 404 errors, and errors might even be cached in CDNs for a while
5151
# - lcginfo.cern.ch: does not support HTTPS, see https://sft.its.cern.ch/jira/browse/SPI-1672
5252
# - http://simul.iro.umontreal.ca/testu01/tu01.html does not support HTTPS
53-
# Reasons for file-ignore
53+
# Reasons for --exclude-path
5454
# - Broken links in historic ROOT v5 release notes
55+
#
5556
# add `--include-fragments` once released!
56-
args: --base build --no-progress --exclude-mail --exclude-path 'build/install/all_releases/' --exclude https://rootbnch-grafana-test.cern.ch --exclude https://lcgapp-services.cern.ch/root-jenkins --exclude https://indico.desy.de --exclude https://nbviewer.jupyter.org --exclude https://www.sciencedirect.com --exclude https://github.com/root-project/web/tree/ --exclude https://twitter.com/ROOT_Project 'build/**/*.html'
57+
args: --base build/ --no-progress --exclude-mail --exclude-path '${PR_NUMBER}/install/all_releases/' --exclude https://rootbnch-grafana-test.cern.ch --exclude https://lcgapp-services.cern.ch/root-jenkins --exclude https://indico.desy.de --exclude https://nbviewer.jupyter.org --exclude https://www.sciencedirect.com --exclude https://github.com/root-project/web/tree/ --exclude https://twitter.com/ROOT_Project ${{ github.event_name == 'pull_request' && '--remap "https://root.cern/${PR_NUMBER} file://" ' || ''}} 'build/**/*.html'
5758
# Fail action on broken links
5859
fail: true
5960

0 commit comments

Comments
 (0)