[Math] Avoid redefinition of VECCORE_ENABLE_VC macro
#677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro should be already set via ${VecCore_DEFINITIONS}, so setting
it here unconditionally is redundant and leads to many warnings.
However, the build system is not quite ready for setting this only via
${VecCore_DEFINITIONS}, so we need to conditionally set it if
dependencies are satisfied and it is not set.
|
Starting build on |
|
Thanks! :) |
|
Build failed on slc6/gcc49. Warnings:
Failing tests: |
|
Build failed on slc6/gcc62. Warnings:
Failing tests: |
|
Build failed on ubuntu14/native. Warnings:
Failing tests: |
|
Build failed on centos7/gcc49. Warnings:
Failing tests: |
|
Build failed on mac1012/native. Warnings:
Failing tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro should be already set via
${VecCore_DEFINITIONS}, so setting it unconditionally is redundant and leads to many warnings. However, the build system is not quite ready for setting this only via${VecCore_DEFINITIONS}, so we need to conditionally set it if dependencies are satisfied and it is not set.