[ntuple] Add test for reading an unknown column type #16516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
force-pushed
the
ntuple_fwd_unknown_col
branch
4 times, most recently
from
fe595f6
to
e7363e4
Compare
Test Results 14 files 14 suites 3d 3h 57m 5s ⏱️ Results for commit 2e465a4. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Sep 24, 2024
pcanal
reviewed
Sep 24, 2024
jblomer
reviewed
Sep 24, 2024
jblomer
reviewed
Sep 24, 2024
silverweed
force-pushed
the
ntuple_fwd_unknown_col
branch
from
e7363e4
to
2e465a4
Compare
pcanal
reviewed
Sep 27, 2024
| @@ -267,6 +267,10 @@ namespace { | |||
| using ROOT::Experimental::EColumnType; | |||
| using ROOT::Experimental::Internal::RColumnElementBase; | |||
|
|
|||
| // testing value for an unknown future column type | |||
| inline constexpr EColumnType kTestFutureType = | |||
There was a problem hiding this comment.
It is in a public header and thus part of the public interface. If we can not move it to a private header, can we put it into the Internal namespace?
There was a problem hiding this comment.
This header is not public, it's in the src directory and only included by our cxx files (see comment on top of the file)
jblomer
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
avoids throwing an exception when creating the descriptor for an RNTuple containing an unknown column type. We want to support this case for forward compatibility. Also adds a unit test testing this specific case.
Some dedicated code needs to be added to the internals of RNTuple to support this kind of test case, but it's not exposed to the user.
Remarks
Currently the test just checks that we can read back the descriptor. A future PR will add a "fwd compatibility mode" to the read options that'll allow a user to reconstruct the model skipping over fields containing unknown column types.
Checklist: