[v628][CI] Add xgboost and scikit-learn to requirements
#15237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
Axel-Naumann,
couet,
lmoneta and
vepadulano
as code owners
guitargeek
changed the title
xgboost and scikit-learn to requirements
Member
|
Can you just add the two commits fixing the test? I have #15236 adding already xgboost and scikit-learn |
Test Results 12 files 12 suites 2d 4h 19m 42s ⏱️ For more details on these failures, see this check. Results for commit 57b121e. |
* avoid warnings with opened file that is not closed
* don't assume the number of features is in the `_features_count`
attribute (that one doesn't exist with xgboost 2.0)
* support the `"reg:squarederror"` target, which is the default
regression target in xgboost 2.0
XGBoost has to be imported before ROOT to avoid crashes because of clashing std::regexp symbols that are exported by cppyy. See also: wlav/cppyy#227
guitargeek
force-pushed
the
xgboost_v628
branch
from
57b121e to
d08e1dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #15183.