Skip to content

Fix DF examples to make them work as notebooks #10446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 26, 2022
Merged

Fix DF examples to make them work as notebooks #10446

merged 5 commits into from
Apr 26, 2022

Conversation

couet
Copy link
Member

@couet couet commented Apr 26, 2022

df107_SingleTopAnalysis.py:

  • fix arguments parsing
  • fix data file access

df106_HiggsToFourLeptons.py:

  • fix data file access

Makefile:

  • Some DF tutorials need PYSPARK_PYTHON to be defined

@couet couet requested review from etejedor and eguiraud April 26, 2022 09:01
@couet couet self-assigned this Apr 26, 2022
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

eguiraud
eguiraud approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@eguiraud eguiraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

etejedor
etejedor reviewed Apr 26, 2022
View reviewed changes
@phsft-bot
Copy link

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

And 4 more

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@couet couet merged commit b46caa6 into root-project:master Apr 26, 2022
@couet couet deleted the df-notebooks-fixes branch April 26, 2022 12:27
@phsft-bot
Copy link

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-26T12:34:18.261Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-26T12:43:12.324Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

ferdymercury added a commit to ferdymercury/root that referenced this pull request Apr 26, 2022
@ferdymercury
specify pyspark
36fd63e 
as in root-project#10446
ferdymercury added a commit to ferdymercury/root that referenced this pull request Apr 26, 2022
@ferdymercury
specify pyspark
39b09d0 
as in root-project#10446
ferdymercury added a commit to ferdymercury/root that referenced this pull request Apr 26, 2022
@ferdymercury
adapt filter for python
23b3998 
as in root-project#10446
@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-26T13:34:29.962Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@phsft-bot
Copy link

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

And 4 more

@phsft-bot
Copy link

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-26T15:32:25.600Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

ferdymercury added a commit to ferdymercury/root that referenced this pull request Apr 29, 2022
@ferdymercury
specify pyspark
c195a44 
as in root-project#10446
ferdymercury added a commit to ferdymercury/root that referenced this pull request Apr 29, 2022
@ferdymercury
adapt filter for python
b12a5bf 
as in root-project#10446
ferdymercury added a commit to ferdymercury/root that referenced this pull request Jul 11, 2022
@ferdymercury
specify pyspark
fcc7737 
as in root-project#10446
ferdymercury added a commit to ferdymercury/root that referenced this pull request Jul 11, 2022
@ferdymercury
adapt filter for python
dd841d4 
as in root-project#10446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etejedor etejedor etejedor approved these changes

@eguiraud eguiraud eguiraud approved these changes

Assignees

@couet couet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@couet @phsft-bot @etejedor @eguiraud