Building built-in libAfterImage fails if build path contains @

[eguiraud]

• Checked for duplicates

Describe the bug

The symptom is the following:

/usr/bin/mkdir -p /data/ssdext4/rdf_scaling/relwithdebinfo@master/include/libAfterImage
installing libAfterImage headers using command -
    "-m 644 <header> /data/ssdext4/rdf_scaling/relwithdebinfo@master/include/libAfterImage" :
afterimage.h afterbase.h ascmap.h asfont.h asim_afterbase.h asimage.h asimagexml.h asstorage.h asvisual.h blender.h bmp.h char2uni.h draw.h export.h imencdec.h import.h pixmap.h scanline.h transform.h ungif.h xcf.h ximage.h xpm.h xwrap.h

/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
/bin/sh: line 30: -m: command not found
gmake[3]: m: Command not found
/bin/sh: line 2: -m: command not found
gmake[3]: *** [Makefile:145: install.static] Error 127

The cause seems to be the sed substitutions at

root/graf2d/asimage/src/libAfterImage/configure

Line 2834 in aee4876

INSTALL=`echo $INSTALL|sed -e "s@\^\.\.@${currdir}@" -e "s@^autoconf@${currdir}/autoconf@"`

(thanks @chrisburr )

@dennisklein mentioned that in homebrew they work around the issue with this patch.

@amadio suggested we should "use / as separator and escape the slashes that are part of the patterns themselves."

To Reproduce

Build ROOT with built-in libafterimage in a directory with a path that contains a @.

Additional context

Further discussion available at https://mattermost.web.cern.ch/root/pl/zszko6zhwjnsprxjk54gu5ye6h

[ChristianTackeGSI]

Using | is also a common solution for this kind of problem.
s|foo@bar/extra|new/value|
I yet have to see someone using a | in their paths… We'll surely get to see that once!