Refactoring simplifying classes #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopraanmol1
added a commit
to chopraanmol1/roo
that referenced
this pull request
Oct 5, 2018
### Summary Fixes roo-rb#378 and roo-rb#374 (Introduced in roo-rb#368) ### Benchmark ``` file_name = 'test/files/Bibelbund.csv' MemoryProfiler.report{ Roo::Spreadsheet.open(file_name).tap{|x|(2..x.last_row).each{|i| x.row(i)}} } puts Benchmark.measure{ Roo::Spreadsheet.open(file_name).tap{|x|(2..x.last_row).each{|i| x.row(i)}} } ``` Master ``` Total allocated: 39705265 bytes (561479 objects) Total retained: 768 bytes (4 objects) 0.300000 0.000000 0.300000 ( 0.304877) ``` Modified: ``` Total allocated: 16952085 bytes (234487 objects) Total retained: 768 bytes (4 objects) 0.190000 0.000000 0.190000 ( 0.181199) ```
chopraanmol1
added a commit
to chopraanmol1/roo
that referenced
this pull request
Oct 5, 2018
### Summary Fixes roo-rb#378 and roo-rb#374 (Introduced in roo-rb#368) ### Benchmark ``` file_name = 'test/files/Bibelbund.csv' MemoryProfiler.report{ Roo::Spreadsheet.open(file_name).tap{|x|(2..x.last_row).each{|i| x.row(i)}} } puts Benchmark.measure{ Roo::Spreadsheet.open(file_name).tap{|x|(2..x.last_row).each{|i| x.row(i)}} } ``` Master ``` Total allocated: 39705265 bytes (561479 objects) Total retained: 768 bytes (4 objects) 0.300000 0.000000 0.300000 ( 0.304877) ``` Modified: ``` Total allocated: 16952085 bytes (234487 objects) Total retained: 768 bytes (4 objects) 0.190000 0.000000 0.190000 ( 0.181199) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring and simplifying classes. Because I want a code climate score above 2.