fix(loudness): tune equalizer defaults to eliminate volume pumping#304
Open
iscle wants to merge 1 commit into
Open
fix(loudness): tune equalizer defaults to eliminate volume pumping#304iscle wants to merge 1 commit into
iscle wants to merge 1 commit into
Conversation
The previous defaults caused audible volume fluctuations ("pumping")
especially at low-to-moderate listening levels:
- 30ms analysis window reacted to individual transients instead of
sustained loudness, causing rapid gain swings on drum hits
- 15 dB max boost created dramatic level changes between quiet and
loud passages
- 5000ms gain release made recovery audibly slow, creating a
"breathing" effect as gain slowly crept back up
- -48 dB noise floor allowed aggressive boosting of near-silence
Tuned defaults:
- analysisWindowMs: 30 → 100 (smooths transients, measures phrases)
- maxBoostDb: 15 → 6 (meaningful lift without dramatic pumping)
- gainAttackMs: 180 → 250 (smoother gain reduction)
- gainReleaseMs: 5000 → 3000 (faster recovery, less "swell")
- detectorReleaseMs: 400 → 600 (holds peaks longer, reduces jitter)
- noiseFloorThresholdDb: -48 → -40 (protects quiet material)
- lowLevelMaxBoostDb: 1.5 → 0.5 (conservative at very low levels)
Closes ronitsingh10#302
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6f8568e to
ff01e2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heads-up: This PR and fix was generated by Claude, but I did manually review it and test it! No sloppy unsupervised AI code here :)
Summary
LoudnessEqualizerSettingsdefaults to eliminate audible volume pumping at low-to-moderate listening levelsDependencies
Problem
The previous default settings caused the
LoudnessEqualizerto produce audible volume fluctuations ("pumping" / "breathing"):analysisWindowMsmaxBoostDbgainAttackMsgainReleaseMsdetectorReleaseMsnoiseFloorThresholdDblowLevelMaxBoostDbTest plan
LoudnessEqualizerTestspass (including updated defaults test)Closes #302
🤖 Generated with Claude Code