-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support newest versions of Ember #31
Comments
As a workaround, you can edit your ember app's // remove jQuery from build because it is already loaded by Rails
var vendor = app._scriptOutputFiles['/assets/vendor.js'];
var index = vendor.indexOf('bower_components/jquery/dist/jquery.js');
if (index > 0) {
vendor.splice(index, 1);
} |
This worked for me after updating to the latest ember-cli and ember (2.5.x) |
Does this only affect |
The disadvantage of @ihoka's workaround is that it nukes jquery entirely from your ember application, meaning it will break your ember-cli tests. I've discovered that ember-cli actually supports excluding a specific asset, so I'm not sure To get my app to work, I customized my ember-cli-build.js with the following to exclude jquery: var app = new EmberApp(defaults, {
vendorFiles: {
'jquery.js': {
test: 'bower_components/jquery/dist/jquery.js',
production: false
}
}
}); Unless I'm missing a use case, I'd suggest removing |
I'm in favor of this. I'll investigate when I have some free cycles (PRs welcome!). |
The newest versions of Ember have altered the way
legacyFilesToAppend
works. This affectsexclude_ember_deps
.Currently, this addon does not work with EmberCLI 2.4.1 or higher.
https://github.com/ember-cli/ember-cli/releases/tag/v2.4.1
The text was updated successfully, but these errors were encountered: