Pretty sequence indexing #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozkriff
reviewed
Jan 24, 2018
src/ser/mod.rs
Outdated
| @@ -97,6 +97,7 @@ impl Default for PrettyConfig { | |||
| new_line: "\r\n".to_string(), | |||
| indentor: " ".to_string(), | |||
| separate_tuple_members: false, | |||
| enumerate_arrays: true, | |||
There was a problem hiding this comment.
Hmmmm, are you sure that this option should be enabled by default?
There was a problem hiding this comment.
Not really. Would you not want to see the indices?
There was a problem hiding this comment.
I agree with @ozkriff, I think it's too noisy for it to be the default.
torkleyy
reviewed
Jan 24, 2018
src/ser/mod.rs
Outdated
| if config.enumerate_arrays { | ||
| //TODO: when /**/ comments are supported, prepend the index | ||
| // to an element instead of appending it. | ||
| // Note: this doesn't if `new_line` is not an actual new line. |
There was a problem hiding this comment.
I suggest we assert that PrettyConfig::new_line contains a b'\n' on creation.
src/ser/mod.rs
Outdated
| @@ -97,6 +97,7 @@ impl Default for PrettyConfig { | |||
| new_line: "\r\n".to_string(), | |||
| indentor: " ".to_string(), | |||
| separate_tuple_members: false, | |||
| enumerate_arrays: true, | |||
There was a problem hiding this comment.
I agree with @ozkriff, I think it's too noisy for it to be the default.
|
@torkleyy thanks for feedback! PTAL |
torkleyy
approved these changes
Jan 24, 2018
|
Thank you! bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 24, 2018
86: Pretty sequence indexing r=torkleyy a=kvark
This is super useful when inspecting serialized vectors for an ability to quicky jump to an element by index. Looks like this:
```rust
array: [
(),// [0]
(),// [1]
(),// [2]
],
```
Ideally, I'd like to see it like this:
```rust
array: [
/*0*/ (),
/*1*/ (),
/*2*/ (),
],
```
But this is blocked on supporting those types of comments.
Build succeeded |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is super useful when inspecting serialized vectors for an ability to quicky jump to an element by index. Looks like this:
Ideally, I'd like to see it like this:
But this is blocked on supporting those types of comments.