Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of struct/variant names starting in None, Some, true, or false #499

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Sep 5, 2023

  • I've included my change in CHANGELOG.md

@juntyr juntyr changed the title Fix consume_str for Some None Fix consume_str for Some and None Sep 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (10021d1) 99.40% compared to head (b5655bf) 99.40%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          78       78           
  Lines       10542    10592   +50     
=======================================
+ Hits        10479    10529   +50     
  Misses         63       63           
Files Changed Coverage Δ
src/de/mod.rs 98.63% <100.00%> (ø)
src/de/tests.rs 100.00% <100.00%> (ø)
src/parse.rs 100.00% <100.00%> (ø)
tests/367_implicit_some.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juntyr juntyr changed the title Fix consume_str for Some and None Fix parsing of struct/enum names starting in None or Some Sep 5, 2023
@juntyr juntyr changed the title Fix parsing of struct/enum names starting in None or Some Fix parsing of struct/variant names starting in None or Some Sep 5, 2023
@juntyr juntyr changed the title Fix parsing of struct/variant names starting in None or Some Fix parsing of struct/variant names starting in None, Some, true, or false Sep 5, 2023
@juntyr juntyr merged commit 9ecb1e5 into ron-rs:master Sep 5, 2023
8 checks passed
@juntyr juntyr deleted the implicit-some-consume-ident branch September 5, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants