Fix #370 with better float EBNF and +inf -NaN +NaN parsing #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
Fixes the RON grammar for floats to be equivalent to
FromStr
's grammar (which we use internally):Consequently, RON now also accepts
+inf
,-NaN
, and+NaN
.In comparison with
rustc
,FromStr
still accepts floats without a leading digit, e.g..3
- these continue to work. The other way around,rustc
accepts underscores in floats whileFromStr
and all other parsers I checked do not. I've added a special errorFloatUnderscore
to lint against this case.CHANGELOG.md