Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #174 #225

Merged
merged 2 commits into from
May 3, 2020
Merged

Fix #174 #225

merged 2 commits into from
May 3, 2020

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented May 2, 2020

Disclaimer: untested; just applies the patch recommended by @torkleyy in #174.

Closes #174.

kvark
kvark approved these changes May 2, 2020
View reviewed changes
Copy link
Collaborator

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was actually doing the same :)
bors r+

bors bot added a commit that referenced this pull request May 2, 2020
@bors @CAD97
Merge #225
4077ffd 
225: Fix #174 r=kvark a=CAD97

Disclaimer: untested; just applies the patch recommended by @torkleyy in #174.

Closes #174.

Co-authored-by: Christopher Durham <cad97@cad97.com>
@bors
Copy link
Contributor

bors bot commented May 2, 2020

Build failed:

@CAD97
Copy link
Contributor Author

CAD97 commented May 2, 2020

Looks like there is a test of the current behavior. I don't actually have this branch locally (and am working on drafting a rewrite version anyway) so I'll let you grab that test.

@kvark
Copy link
Collaborator

kvark commented May 3, 2020

Well, since you made a PR first, you ought to finish it by correcting the tests expectations :)

@CAD97
Copy link
Contributor Author

CAD97 commented May 3, 2020 •
edited
Loading

Oh, alright, I'll pull out my git stash and fix this 😄 (I did)

@kvark
Copy link
Collaborator

kvark commented May 3, 2020

bors try

bors bot added a commit that referenced this pull request May 3, 2020
@bors
Try #225:
068c6f1
@bors
Copy link
Contributor

bors bot commented May 3, 2020

try

Build succeeded:

@kvark kvark merged commit ecdcd83 into ron-rs:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depth limit seems to be off by one
2 participants
@CAD97 @kvark