Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Out of memory will caclulating checksum of compressed files #1262

Open
taki-eddine-47 opened this issue Oct 26, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@taki-eddine-47
Copy link

RomM version
3.5.1

Describe the bug
I found that ROMM use a lot of memory when scannes 7z files (big size).

To Reproduce
Steps to reproduce the behavior:

  1. Add new compressed file in any library with large size (ex: 100GB)
  2. Start a Complete rescan for that library
  3. Watch the memory usage of ROMM worker process.
  4. Wait until system crashes 🥲.

Expected behavior
ROMM should use better way to calculate the hashe of a file without loading it all in memory (read and calculate by chunk ?).

Screenshots
image

Desktop (please complete the following information):

  • OS: K3S (NixOS)
  • Browser: Firefox
  • Version: 131

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

rom_hashes = fs_rom_handler.get_rom_hashes(rom_attrs["file_name"], roms_path)

for chunk in read_7z_file(file_path):

for _name, bio in f.readall().items():

@taki-eddine-47 taki-eddine-47 added the bug Something isn't working label Oct 26, 2024
@danblu3
Copy link

danblu3 commented Oct 29, 2024

#1226

Aware and being worked on for future release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants