Skip to content

Latest commit

 

History

History
9 lines (5 loc) · 744 Bytes

H-04.md

File metadata and controls

9 lines (5 loc) · 744 Bytes
Raw

Mitigation of H-04: Issue mitigated, see comments

Link to Issue: code-423n4/2023-03-asymmetry-findings#641

Comments

The original issue describes an error in the calculation of ethPerDerivative() for the SfrxEth derivative. The fix described in the report for H-04 is straightforward, however the protocol team decided to change the whole implementation of this function in favor of using Chainlink, probably linked to issue H-08 which describes oracle price manipulation attacks.

While technically the issue described in H-04 is mitigated, as the whole code was replaced, the mitigation introduces a new issue related to the 1:1 frxETH assumption, which is described in a separate report [adriro-NEW-H-01].