Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 noUselessConstructor removes default properties #4781

Closed
1 task done
stutrek opened this issue Aug 25, 2023 · 3 comments · Fixed by biomejs/biome#71
Closed
1 task done

🐛 noUselessConstructor removes default properties #4781

stutrek opened this issue Aug 25, 2023 · 3 comments · Fixed by biomejs/biome#71
Assignees
Labels
S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@stutrek
Copy link

stutrek commented Aug 25, 2023

Environment information

CLI:
  Version:                      12.1.3-nightly.4c8cf32
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v16.14.2"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/8.5.0"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           true
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      12.1.3

Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      <=10.0.0

Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      12.1.3-nightly.f65b0d9

Running Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ The client isn't connected to any server but rage discovered this running Rome server.

Server:
  Version:                      12.1.3-nightly.4c8cf32
  Name:                         rome_lsp
  CPU Architecture:             aarch64
  OS:                           macos

Workspace:
  Open Documents:               0

Other Active Server Workspaces:

Workspace:
  Open Documents:               5
  Client Name:                  Visual Studio Code
  Client Version:               1.81.1

What happened?

noUselessConstructor is removing a constructor that adds a default property.

image

This constructor is relevant because it changes the default error message.

Expected result

It should not remove this constructor.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@stutrek stutrek added the S-To triage Status: user report of a possible bug that needs to be triaged label Aug 25, 2023
@Conaclos Conaclos added S-Bug: confirmed Status: report has been confirmed as a valid bug and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Aug 25, 2023
@Conaclos Conaclos self-assigned this Aug 25, 2023
@stutrek
Copy link
Author

stutrek commented Aug 25, 2023

Thank you!

What is Biome? How does it relate to Rome?

@Conaclos
Copy link
Contributor

Conaclos commented Aug 25, 2023

What is Biome? How does it relate to Rome?

It is the community successor of Rome Tools. Same team, but with a different name. It is not publicly announced yet. Be patient and keep the “secret” until the fork is publicly announced (certainly in some days). The fix will be available in the first release which will come at the same time as the announcement. :)

@Conaclos
Copy link
Contributor

Biome is now publicly announced. You can test the fix on the first stable release of Biome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants