Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Rome Extension ignores rome.json configuration on Windows #3182

Closed
1 task done
ZachHaber opened this issue Sep 7, 2022 · 0 comments · Fixed by #3185
Closed
1 task done

🐛 Rome Extension ignores rome.json configuration on Windows #3182

ZachHaber opened this issue Sep 7, 2022 · 0 comments · Fixed by #3185
Assignees
Labels
A-LSP Area: language server protocol E-VScode Editors: VSCode P-Windows Platform: Windows S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@ZachHaber
Copy link

Environment information

Rome Extension: v0.14.0
No Rome CLI installed globally or locally,

VSCode Env Info:
Version: 1.71.0 (system setup)
Commit: 784b0177c56c607789f9638da7b6bf3230d47a8c
Date: 2022-09-01T07:36:10.600Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No

What happened?

On Windows, the path for the config file from VSCode gets mangled so that it is unable to find the file.

The path ends up being something like "/c%3A/code/redactinator\rome.json", which encodes the : as part of the drive letter.

server.log.zip

l3ops in Discord

I think that's because the language server receives the path to the workspace root folder as a file:// URL from the editor, it seems we turn it into a filesystem path by extracting the path segment of the URI but on Windows that's not sufficient and we need to actually parse it

Expected result

The Rome Extension Language Service should be able to read the configuration in a VSCode project on windows without issue.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@ZachHaber ZachHaber added the S-To triage Status: user report of a possible bug that needs to be triaged label Sep 7, 2022
@leops leops self-assigned this Sep 8, 2022
@leops leops added S-Bug: confirmed Status: report has been confirmed as a valid bug A-LSP Area: language server protocol E-VScode Editors: VSCode P-Windows Platform: Windows and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-LSP Area: language server protocol E-VScode Editors: VSCode P-Windows Platform: Windows S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants