Run p2p block parsing and processing concurrently #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
approved these changes
Aug 31, 2021
Contributor
Kixunil
left a comment
Kixunil
left a comment
There was a problem hiding this comment.
LGTM. I wonder if fetching and processing multiple blocks concurrently would help.
Contributor
|
Strong Concept ACK ! I am too new to Rust to fully ACK this code but from the little I know in concurrency in Rust it looks good ! |
Pantamis
reviewed
Aug 31, 2021
romanz
force-pushed
the
p2p-concurrent
branch
from
f082b55 to
e1ec17c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.