feat(alias)!: resolve entry id

[bluwy]

Rollup Plugin Name: alias

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking. - Added

List any relevant issue numbers:
fix #1190

Description

When the Rollup input is passed an aliased path, the alias plugin doesn't resolve it because it skips if there's no importer. I tracked this behaviour, and found it was not done in the past due to rollup/rollup-plugin-alias#29, but since the internals changed now, that PR's issue isn't relevant and we can continue to alias entry paths now.

[bluwy]

My bad. Didn't notice my syntax in the other PR would also close this. Re-opened and it should still be good to go.

[shellscape]

but since the internals changed now

could you link to the internals you mentioned?

[bluwy]

The old plugin code used to rely on the importer at https://github.com/rollup/rollup-plugin-alias/blob/0204677c0e1112cba7a5a0f60204ff1df81493b0/src/index.js#L80. Now we're not doing that anymore (we don't use the path nodejs module either). We're only passing the importer to the customResolver, which is currently correctly typed that importer could be defined.

[shellscape]

Makes sense, thanks. I'd like to get another approval from another maintainer before we merge.