Add TypeScript-aware linting via typescript-eslint (#1429)

Author: matux

eslint.config.js

@@ -1,22 +1,39 @@
 import babelParser from '@babel/eslint-parser';
 import js from '@eslint/js';
 import { defineConfig } from 'eslint/config';
+import chaiFriendly from 'eslint-plugin-chai-friendly';
 import importPlugin from 'eslint-plugin-import';
 import prettierRecommended from 'eslint-plugin-prettier/recommended';
 import unusedImports from 'eslint-plugin-unused-imports';
 import globals from 'globals';
+import ts from 'typescript-eslint';
 
-export default defineConfig([
+const noUnusedVarsRule = [
+  'error',
+  {
+    argsIgnorePattern: '^_',
+    varsIgnorePattern: '^_',
+    caughtErrorsIgnorePattern: '^_',
+  },
+];
+
+export default defineConfig(
   js.configs.recommended,
+  ts.configs.recommended,
+  ts.configs.stylistic,
   prettierRecommended,
+  chaiFriendly.configs.recommendedFlat,
 
+  // all files
   {
     languageOptions: {
       ecmaVersion: 2021,
+      sourceType: 'module',
     },
     plugins: {
       import: importPlugin,
       'unused-imports': unusedImports,
+      'chai-friendly': chaiFriendly,
     },
     rules: {
       complexity: ['error', { max: 35 }],
@@ -42,32 +59,44 @@ export default defineConfig([
           'newlines-between': 'always',
         },
       ],
-      'no-unused-vars': [
+      'no-unused-vars': noUnusedVarsRule,
+      '@typescript-eslint/no-unused-vars': noUnusedVarsRule,
+      '@typescript-eslint/no-empty-function': [
         'error',
         {
-          argsIgnorePattern: '^_',
-          varsIgnorePattern: '^_',
-          caughtErrorsIgnorePattern: '^_',
+          allow: ['arrowFunctions'],
         },
       ],
+
+      // disabled for now
+      '@typescript-eslint/consistent-indexed-object-style': 'off',
+      '@typescript-eslint/consistent-type-assertions': 'off',
+      '@typescript-eslint/consistent-type-definitions': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-this-alias': 'off',
+      '@typescript-eslint/prefer-for-of': 'off',
+      '@typescript-eslint/prefer-function-type': 'off',
+      'chai-friendly/no-unused-expressions': 'off',
+      'no-undef': 'off',
+      'no-var': 'off',
     },
   },
 
   // globals
   {
-    files: ['test/**/*.js'],
+    files: ['test/**/*.[tj]s'],
     languageOptions: { globals: { ...globals.mocha } },
   },
   {
-    files: ['src/**/*.{js,cjs}', 'test/**/*.js'],
+    files: ['src/**/*.c?[tj]s', 'test/**/*.[tj]s'],
     languageOptions: { globals: { ...globals.browser } },
   },
   {
     files: [
-      'src/server/**/*.js',
-      'src/react-native/**/*.js',
-      'test/**/server.*.js',
-      'scripts/**/*.js',
+      'src/server/**/*.[tj]s',
+      'src/react-native/**/*.[tj]s',
+      'test/**/server.*.[tj]s',
+      'scripts/**/*.[tj]s',
     ],
     languageOptions: { globals: { ...globals.node } },
   },
@@ -82,14 +111,34 @@ export default defineConfig([
         ecmaVersion: 2021,
       },
     },
-    rules: { strict: ['error', 'safe'] },
+    rules: {
+      strict: ['error', 'safe'],
+      '@typescript-eslint/no-unused-vars': 'off',
+    },
+  },
+
+  // ts
+  {
+    files: ['**/*.ts'],
+    rules: {
+      'no-unused-vars': 'off',
+    },
   },
 
   // cjs
   {
     files: ['**/*.cjs'],
     languageOptions: { sourceType: 'commonjs' },
-    rules: { strict: 'off' },
+    rules: {
+      strict: 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+    },
+  },
+
+  // tests
+  {
+    files: ['test/**/*.[tj]s'],
+    rules: { '@typescript-eslint/no-empty-function': 'off' },
   },
 
   // scripts
@@ -101,4 +150,4 @@ export default defineConfig([
   {
     ignores: ['dist', 'examples', 'node_modules', 'vendor', 'coverage'],
   },
-]);
+);

index.d.ts

@@ -304,7 +304,7 @@ declare namespace Rollbar {
     plugins?: any[];
   }
 
-  export type TransformSpanParams = { span: any; }
+  export type TransformSpanParams = { span: any };
   export interface TracingOptions {
     enabled?: boolean;
     endpoint?: string;