Fix picture raster cache throttling (flutter#13710)

liyuqian · web-flow · commit 9e6d36017758 · 2019-11-20T16:36:23.000-08:00
Previously, we're also counting the pictures that are already raster cached. This fixes flutter/flutter#44252 and helps solving the GPU thread issue of flutter/flutter#43083 flutter/flutter#45050 is a performance test in the framework repo to reveal this bug.
diff --git a/flow/raster_cache.cc b/flow/raster_cache.cc
@@ -219,8 +219,8 @@ bool RasterCache::Prepare(GrContext* context,
   if (!entry.image.is_valid()) {
     entry.image = RasterizePicture(picture, context, transformation_matrix,
                                    dst_color_space, checkerboard_images_);
+    picture_cached_this_frame_++;
   }
-  picture_cached_this_frame_++;
   return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -219,8 +219,8 @@ bool RasterCache::Prepare(GrContext* context,`
`219`	`219`	`if (!entry.image.is_valid()) {`
`220`	`220`	`entry.image = RasterizePicture(picture, context, transformation_matrix,`
`221`	`221`	`dst_color_space, checkerboard_images_);`
	`222`	`+ picture_cached_this_frame_++;`
`222`	`223`	`}`
`223`		`- picture_cached_this_frame_++;`
`224`	`224`	`return true;`
`225`	`225`	`}`
`226`	`226`