GH-17: [Python] Fix unknown-argument #36

rok · 2025-07-22T14:47:00Z

Rationale for this change

Part of #5.

What changes are included in this PR?

Fixes the unknown-argument. This comes from trying to use object as context manager and instantiating it with named parameters. Added MockContextManager for testing these cases.

Are these changes tested?

Yes, locally, type checking passes.

Are there any user-facing changes?

No.

GitHub Issue: unknown-argument #17

The main problem was that these were annotated as instance methods rather than static/class methods, but I've added some detail, too.

Fix stubs for Table factory methods

chore: update pre-commit

…s classmethod

fix: make fs.FileSystem.from_uri and hdfs.HadoopFileSystem.from_uri as classmethod

This reverts commit 1631f39.

Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com>

This reverts commit 7ee3d2f.

github-actions · 2025-07-22T14:47:27Z

⚠️ GitHub issue #17 has been automatically assigned in GitHub to PR creator.

github-actions · 2025-07-22T14:47:27Z

⚠️ GitHub issue #17 has no components, please add labels for components.

github-actions · 2025-07-24T15:12:39Z

⚠️ GitHub issue #17 has no components, please add labels for components.

github-actions · 2025-07-24T17:25:29Z

⚠️ GitHub issue #17 has no components, please add labels for components.

* Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix unknown-argument --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>

* Add typing to arrow using stubs * GH-7: [Python] Fix invalid-context-manager error (#30) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix invalid-context-manager --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-8: [Python] Fix invalid-type-form (#31) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix invalid-type-form errors --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-9: [Python] Fix non-subscriptable error (#32) * fix: The type parameter of array should be covariant (apache#253) * release 20.0.0.20250716 (apache#254) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix non-subscriptable issues --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-11: [Python] Fix no-matching-overload error (#34) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix no-matching-overload --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-12: [Python] Fix `invalid-return-type` error (#25) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix `invalid-return-type` error * Fix linting --------- Co-authored-by: Rok Mihevc <rok@mihevc.org> * GH-14: [Python] Fix `not-iterable` typing (#26) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix `not-iterable` error --------- Co-authored-by: Rok Mihevc <rok@mihevc.org> * GH-15: [Python] Fix possibly-unbound-attribute (#38) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix possibly-unbound-attribute --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-16: [Python] Fix too-many-positional-arguments (#35) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix too-many-positional-arguments --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-17: [Python] Fix unknown-argument (#36) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix unknown-argument --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-18: [Python] Fix unresolved-attribute (#37) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix unresolved-attribute --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-19: [Python] Fix unresolved-global (#39) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix unresolved-global --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-20: [Python] Fix `unsupported-reference` typing (#24) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix `unresolved-reference` error --------- Co-authored-by: Rok Mihevc <rok@mihevc.org> * GH-6: [Python] Fix invalid-argument-type error (#29) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * removing OrderedDict, etc --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-27: [Python] Fix call-non-callable error (#28) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * to_sparse appears deprecated, ignore inline * Update python/pyarrow/tests/test_feather.py --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-10: [Python] Fix invalid-assignment error (#33) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unresolved-reference` error * Revert "Fix `unresolved-reference` error" This reverts commit 7ee3d2f. * Fix invalid-assignment --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com> * GH-21: [Python] Fix `unsupported-operator` typing (#22) * Add py.typed file to signify that the library is typed See the relevant PEP https://peps.python.org/pep-0561 * Prepare `pyarrow-stubs` for history merging MINOR: [Python] Prepare `pyarrow-stubs` for history merging Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com> * Add `ty` configuration and suppress error codes * One line per rule * Add licence header from original repo for all `.pyi` files * Revert "Add licence header from original repo for all `.pyi` files" This reverts commit 1631f39. * Prepare for licence merging * Exclude `stubs` from `rat` test * Add Apache licence clause to `py.typed` * Reduce list * Add `ty` as a step in the action * Run in the correct directory * Remove `check` from `pip` * Fix `unsupported-operator` error --------- * fix unsupported-operator * Fix unresolved-reference * Fix not-iterable * Fix no-matching-overload * Fix invalid-assignment * Fix too-many-positional-arguments * Fix invalid-argument-type * Fix missing-argument * Fix unresolved-import * Fix possibly-unbound-import * Fix possibly-unbound-import * Fix unresolved-attribute * Revert test changes * Converging --------- Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>

zen-xu and others added 30 commits December 21, 2022 14:17

Initial commit

1059230

init project

516b35f

complete most of the annotations

5738e6e

fix FixedSizeBufferWriter init annotation

49f64d3

bump 10.0.1.2

e432726

complete parquet core annotations

1b330f0

bump 10.0.1.3

eca9a4b

re-export modules

f5d26a4

fix: add return type for foreign_buffer

697b875

fix output_stream and read_message annotations

bf0edc0

ci: add release job

ba659b3

pre-commit specify flake8 version to 5.0.4

f6f53f6

flake8 ignore F821 for private files

fecc6ef

optimize annotations

3215f5b

bump 10.0.1.4

73235b2

if param supports IOBase, it should also support NativeFile

3d5857d

bump 10.0.1.5

108bbd1

pre-commit adds mypy lint

4c9e6c9

bump 10.0.1.6

a182e01

fix ci name

45909ac

Remove version restrictions for Python.

d2dce33

release 10.0.1.7

736a6ea

update poetry ci

ecfdb8c

Fix stubs for Table factory methods

c630066

The main problem was that these were annotated as instance methods rather than static/class methods, but I've added some detail, too.

Merge pull request #3 from TallJimbo/patch-1

607d7cf

Fix stubs for Table factory methods

update pre-commit

8d5a1e0

update

13b887d

Merge pull request #9 from zen-xu/update-pre-commit

6c44fde

chore: update pre-commit

fix: make fs.FileSystem.from_uri and hdfs.HadoopFileSystem.from_uri a…

e6c7193

…s classmethod

Merge pull request #10 from zen-xu/fix-from-uri

4264ab4

fix: make fs.FileSystem.from_uri and hdfs.HadoopFileSystem.from_uri as classmethod

paddyroddy and others added 13 commits July 20, 2025 12:27

Revert "Add licence header from original repo for all .pyi files"

6d3d972

This reverts commit 1631f39.

Prepare for licence merging

b919150

Merge remote-tracking branch 'two/tmp' into add-typing

fb48bba

Co-authored-by: ZhengYu, Xu <zen-xu@outlook.com>

Exclude stubs from rat test

e1d078f

Add Apache licence clause to py.typed

aa3289c

Reduce list

e41ac42

Add ty as a step in the action

1d3fe98

Merge branch 'add-typing' into typing-ci

a8bf915

Run in the correct directory

9e6c31d

Remove check from pip

b74bacc

Fix unresolved-reference error

7ee3d2f

Revert "Fix unresolved-reference error"

3563575

This reverts commit 7ee3d2f.

Fix unknown-argument

a75a4a8

rok linked an issue Jul 22, 2025 that may be closed by this pull request

unknown-argument #17

Closed

github-actions bot added Component: Python awaiting committer review labels Jul 22, 2025

Base automatically changed from typing-ci to main July 24, 2025 15:08

rok force-pushed the main branch 3 times, most recently from 5354959 to 2cf52b4 Compare July 24, 2025 16:55

rok changed the base branch from main to add-pyarrow-stubs July 24, 2025 17:25

Merge branch 'add-pyarrow-stubs' into unknown-argument

085ad7b

rok merged commit 8da5535 into add-pyarrow-stubs Jul 24, 2025
34 of 52 checks passed

rok deleted the unknown-argument branch July 24, 2025 18:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH-17: [Python] Fix unknown-argument #36

GH-17: [Python] Fix unknown-argument #36

Uh oh!

rok commented Jul 22, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 24, 2025

Uh oh!

github-actions bot commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

22 participants

GH-17: [Python] Fix unknown-argument #36

GH-17: [Python] Fix unknown-argument #36

Uh oh!

Conversation

rok commented Jul 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 24, 2025

Uh oh!

github-actions bot commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

22 participants

rok commented Jul 22, 2025 •

edited by github-actions bot

Loading