Skip to content

Commit 9434b6f

Browse files
committed
Update to Docker image to use Trixie (slim) instead of Bookwork (also slim) and reordered some of the build steps, so ensure a functional build
1 parent 84bd099 commit 9434b6f

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

CHANGELOG.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,18 @@
22

33
## 0.53.0, 2025-10-25, maintenance release, update not required
44

5-
- Docker image updated to Python 3.14.0 bookworm slim [Release notes for Python 3.14.0](https://docs.python.org/release/3.14.0/whatsnew/changelog.html)
6-
7-
- Bumped the requirement for cython to `3.0.11` or above, addressing a build issue with lxml, located when testing the PR : [#274](https://github.com/rojopolis/spellcheck-github-actions/pull/274) from @dependabot, the above updated of Python
5+
- Docker image updated to Python 3.14.0 trixie slim [Release notes for Python 3.14.0](https://docs.python.org/release/3.14.0/whatsnew/changelog.html), this originated from the PR mentioned below, however updated to Trixie from Bookworm and as always the slim variant is used
6+
7+
- Bumped the requirement for cython to `3.0.11` or above, addressing a build issue with lxml, located when testing the PR : [#274](https://github.com/rojopolis/spellcheck-github-actions/pull/274) from @dependabot, the above update of Python
8+
9+
- In general the Docker build file had a few updates since the above changes required some tweaking of the Dockerfile
10+
- Order of installation of dependencies adjusted to ensure that lxml can build correctly
11+
- Installation of:
12+
- build-essential
13+
- pkg-config
14+
- libxml2-dev
15+
- libxslt1-dev
16+
- zlib1g-dev
817

918
## 0.52.0, 2025-09-10, feature release, update not required
1019

Dockerfile

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# REF: https://hub.docker.com/_/python
2-
# Python 3.13.7-slim-bookworm
3-
FROM python@sha256:e3a6ccbe44d9cbfa4f107f238a0e95fa70e0d084e87689222e951d062ac89854
2+
# Python 3.14.0-slim-trixie
3+
FROM python@sha256:4ed33101ee7ec299041cc41dd268dae17031184be94384b1ce7936dc4e5dead3
44

55
LABEL "com.github.actions.name"="Spellcheck Action"
66
LABEL "com.github.actions.description"="Check spelling of files in repository"
@@ -17,11 +17,11 @@ COPY constraint.txt /constraint.txt
1717
COPY spellcheck.yaml /spellcheck.yaml
1818
COPY pwc.py /pwc.py
1919

20-
ENV PIP_CONSTRAINT=/constraint.txt
21-
RUN pip3 install -r /requirements.txt
22-
2320
# REF: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get
2421
RUN apt-get update && apt-get install -y \
22+
build-essential pkg-config \
23+
libxml2-dev libxslt1-dev \
24+
zlib1g-dev \
2525
aspell hunspell \
2626
aspell-en hunspell-en-au hunspell-en-ca hunspell-en-gb hunspell-en-us \
2727
aspell-de hunspell-de-at hunspell-de-ch hunspell-de-de \
@@ -32,5 +32,8 @@ RUN apt-get update && apt-get install -y \
3232
aspell-it hunspell-it \
3333
&& rm -rf /var/lib/apt/lists/*
3434

35+
ENV PIP_CONSTRAINT=/constraint.txt
36+
RUN pip3 install -r /requirements.txt
37+
3538
WORKDIR /tmp
3639
ENTRYPOINT ["/bin/bash", "/entrypoint.sh"]

0 commit comments

Comments
 (0)