Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: roidrage/redis-session-store
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.6.4
Choose a base ref
...
head repository: roidrage/redis-session-store
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.5
Choose a head ref
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 4, 2014

  1. Remove useless private declaration 

    Thanks @jjeb #36
    @dplummer
    dplummer committed Apr 4, 2014
    Configuration menu
    Copy the full SHA
    d8ddc65 View commit details
    Browse the repository at this point in the history

  2. Test for sid collision #36 

    A bit contrived, but does demonstrate the problem. If two processes
randomly generate the same sid, a collision is possible. There is a
window between the `get` call in `sid_collision?` and the `set` call in
`set_session` where another process could set the same sid.

This should be fixed by using `setnx` in `sid_collision?`.
    @dplummer
    dplummer committed Apr 4, 2014
    Configuration menu
    Copy the full SHA
    0d059ae View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2014

  1. Fix colliding sid issue #36

    @dplummer
    dplummer committed Apr 5, 2014
    Configuration menu
    Copy the full SHA
    89676b6 View commit details
    Browse the repository at this point in the history

  2. Prep for v0.6.5 release

    @dplummer
    dplummer committed Apr 5, 2014
    Configuration menu
    Copy the full SHA
    cdf521e View commit details
    Browse the repository at this point in the history
Loading