Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Integrate video.js to the landing page #445

Open
rohitdasu opened this issue Jan 28, 2024 · 23 comments
Open

[FEATURE] Integrate video.js to the landing page #445

rohitdasu opened this issue Jan 28, 2024 · 23 comments
Assignees
Labels
enhancement New feature or request feature new feature frontend frontend related task good first issue Good for newcomers

Comments

@rohitdasu
Copy link
Owner

Description

We currently feature a video demo on our landing page using a basic Vimeo player. To enhance customization options and improve the visual appeal, we aim to integrate video.js. This upgrade will provide us with a wider range of customization possibilities, ensuring a more polished and visually pleasing presentation.

Current state:
Screenshot 2024-01-28 at 5 43 19 PM

@rohitdasu rohitdasu added feature new feature enhancement New feature or request good first issue Good for newcomers frontend frontend related task labels Jan 28, 2024
@rohitdasu
Copy link
Owner Author

@mfrezghi
Copy link

Hey @rohitdasu, can I take this issue?

@rohitdasu
Copy link
Owner Author

Hey @rohitdasu, can I take this issue?

Sure :)

@mfrezghi
Copy link

Cool, thanks!

@mfrezghi
Copy link

Not finding much information on how to integrate Vimeo with Video.js, it looks like videojs7-vimeo is not well supported anymore

Did find this though: https://stackoverflow.com/questions/74304182/best-practice-to-embed-vimeo-video-in-nextjs-or-reactjs

It looks like you can achieve a lot more customization using ReactPlayer. LMK if you want to try that out, or if you'd rather find a way to use video.js, thanks!

@rohitdasu
Copy link
Owner Author

hi @mfrezghi, i don't mind using React-Player if it has customization better than the current one which we are using. Please integrate it with react-player and create a PR. would love to review it. thanks.

@mfrezghi
Copy link

mfrezghi commented Feb 2, 2024

Sounds good! I'll try it out.

@mfrezghi
Copy link

mfrezghi commented Feb 2, 2024

Hi @rohitdasu, it looks like even when I use React-Player, it still defaults to iFrame on your site. After some research this looks like an issue that a handful of people have encountered. From what I've been reading, people either use this for further customization: https://help.vimeo.com/hc/en-us/articles/12426259745937-Customize-the-video-player
Or use something other than Vimeo... Sorry I couldn't get this working for you 😅

@mfrezghi mfrezghi removed their assignment Feb 2, 2024
@rohitdasu
Copy link
Owner Author

no problem @mfrezghi

I appreciate your efforts. please keep looking for new issues. Thank You :)

@Apurv428
Copy link

Hi @rohitdasu , can I work on this issue?

@rohitdasu
Copy link
Owner Author

@Apurv428 sure, go ahead. let us know if you need anything. thanks

@Apurv428
Copy link

Apurv428 commented Feb 11, 2024

image

@rohitdasu There's an issue with loading the video. I need to refactor this part to video.js, right?

@Apurv428
Copy link

Hi @rohitdasu, I am facing the below error, Can you please help me out?

Error: MongoDB error
Server selection timeout: No available servers. Topology: { Type: Unknown, Servers: [ { Address: mongo:27017, Type: Unknown, Error: No such host is known. (os error 11001) }, ] }
0: migration_core::commands::schema_push::Calculate from
at migration-engine\core\src\commands\schema_push.rs:46
1: migration_core::state::SchemaPush
at migration-engine\core\src\state.rs:433

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@rohitdasu
Copy link
Owner Author

image

@rohitdasu There's an issue with loading the video. I need to refactor this part to video.js, right?

you're right.

@rohitdasu
Copy link
Owner Author

Hi @rohitdasu, I am facing the below error, Can you please help me out?

Error: MongoDB error Server selection timeout: No available servers. Topology: { Type: Unknown, Servers: [ { Address: mongo:27017, Type: Unknown, Error: No such host is known. (os error 11001) }, ] } 0: migration_core::commands::schema_push::Calculate from at migration-engine\core\src\commands\schema_push.rs:46 1: migration_core::state::SchemaPush at migration-engine\core\src\state.rs:433

error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

have you created a mongodb uri in mongodb atlas?

@Apurv428
Copy link

Yeah, it got solved. But on running yarn prisma db seed, I am getting the following error

image

@Apurv428
Copy link

Hi
As per my understanding, for the vimeo video, we can only use iframe
When I tried to access it using the video.js, I am facing the error code 401 and 403.
Can you please provide the alternate video source so that I can give it a shot?
Screenshot (119)

@rohitdasu
Copy link
Owner Author

@Apurv428 the 4XX error is not related to the video.js I think.

@Apurv428
Copy link

Apurv428 commented Mar 3, 2024

The vimeo video can be accessed when opened on new tab but not in video.js

@rohitdasu
Copy link
Owner Author

hi @Apurv428 can we connect over discord?

@Apurv428
Copy link

Apurv428 commented Mar 3, 2024

Yeah Sure!
Discord id: apurv9742

@Apurv428
Copy link

Apurv428 commented Mar 5, 2024

Hey @rohitdasu can you share me your discord id?

@rohitdasu
Copy link
Owner Author

@Apurv428 could you join our discord server? link is in the landing page of the site. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature new feature frontend frontend related task good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants