Merge pull request tgalopin#22 from tgalopin/fix-details-ext

Fix details extension and add custom allowed attr test

Author: tgalopin

src/Extension/Details/Node/DetailsNode.php

@@ -27,11 +27,4 @@ public function getTagName(): string
     {
         return 'details';
     }
-
-    public function render(): string
-    {
-        $isOpen = null !== $this->getAttribute('open');
-
-        return '<details'.($isOpen ? ' open="open"' : '').'>'.$this->renderChildren().'</details>';
-    }
 }

src/Extension/Details/NodeVisitor/DetailsNodeVisitor.php

@@ -39,6 +39,12 @@ public function getDefaultAllowedAttributes(): array
 
     protected function createNode(\DOMNode $domNode, Cursor $cursor): NodeInterface
     {
-        return new DetailsNode($cursor->node);
+        $node = new DetailsNode($cursor->node);
+
+        if (null !== $this->getAttribute($domNode, 'open')) {
+            $node->setAttribute('open', 'open');
+        }
+
+        return $node;
     }
 }