Skip to content

Commit a536ea1

Browse files
shivamverma-msshivamverma-ms
authored
Custom Resource Naming (Azure#406)
* Custom Resource Naming Feature * Remove Logs * Refactoring if/else statements * logic changed * resolving comments * resource naming logic changed * added check for diskMapping Length>0 * remove log statement
1 parent 50789f5 commit a536ea1

File tree

2 files changed

+90
-2
lines changed

2 files changed

+90
-2
lines changed

‎azure-migrate/migrate-at-scale-vmware-agentles/Agentless VMware automation/AzMigrate_UpdateMachineProperties.ps1

+88
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,76 @@ Function ProcessItemImpl($processor, $csvItem, $reportItem) {
235235
}
236236
#End Code for Target Subscription
237237

238+
$targetDiskName = $csvItem.UPDATED_TARGET_DISK_NAME
239+
if ([string]::IsNullOrEmpty($targetDiskName)) {
240+
$processor.Logger.LogTrace("UPDATED_TARGET_DISK_NAME is not mentioned for: '$($sourceMachineName)'")
241+
}
242+
else {
243+
$params.Add("TargetDiskName", $targetDiskName)
244+
}
245+
246+
$diskMapping = @()
247+
$paramsDisk1 = @{}
248+
$osDiskId = $csvItem.OS_DISK_ID
249+
$osDiskName = $csvItem.UPDATED_TARGET_OS_DISK_NAME
250+
251+
if ([string]::IsNullOrEmpty($osDiskId)) {
252+
$processor.Logger.LogTrace("OS_DISK_ID is not mentioned for: '$($sourceMachineName)'")
253+
$reportItem.AdditionalInformation = "OS_DISK_ID is not mentioned for: '$($sourceMachineName)'"
254+
}
255+
else {
256+
$paramsDisk1.Add("DiskId", $osDiskId)
257+
$paramsDisk1.Add("IsOSDisk", $true)
258+
if ([string]::IsNullOrEmpty($osDiskName)) {
259+
$processor.Logger.LogTrace("UPDATED_TARGET_OS_DISK_NAME is not mentioned for: '$($sourceMachineName)'")
260+
}
261+
else {
262+
$paramsDisk1.Add("TargetDiskName", $osDiskName)
263+
}
264+
$diskMapping+= $paramsDisk1
265+
}
266+
267+
$paramsDisk2 = @{}
268+
$dataDisk1Id = $csvItem.DATA_DISK1_ID
269+
$dataDisk1Name = $csvItem.UPDATED_TARGET_DATA_DISK1_NAME
270+
if ([string]::IsNullOrEmpty($dataDisk1Id)) {
271+
$processor.Logger.LogTrace("DATA_DISK1_ID is not mentioned for: '$($sourceMachineName)'")
272+
$reportItem.AdditionalInformation = "DATA_DISK1_ID is not mentioned for: '$($sourceMachineName)'"
273+
}
274+
else {
275+
$paramsDisk2.Add("DiskId", $dataDisk1Id)
276+
$paramsDisk2.Add("IsOSDisk", $false)
277+
if ([string]::IsNullOrEmpty($dataDisk1Name)) {
278+
$processor.Logger.LogTrace("UPDATED_TARGET_DATA_DISK1_NAME is not mentioned for: '$($sourceMachineName)'")
279+
}
280+
else {
281+
$paramsDisk2.Add("TargetDiskName", $dataDisk1Name)
282+
}
283+
$diskMapping+= $paramsDisk2
284+
}
285+
286+
$paramsDisk3 = @{}
287+
$dataDisk2Id = $csvItem.DATA_DISK2_ID
288+
$dataDisk2Name = $csvItem.UPDATED_TARGET_DATA_DISK2_NAME
289+
if ([string]::IsNullOrEmpty($dataDisk2Id)) {
290+
$processor.Logger.LogTrace("DATA_DISK2_ID is not mentioned for: '$($sourceMachineName)'")
291+
$reportItem.AdditionalInformation = "DATA_DISK2_ID is not mentioned for: '$($sourceMachineName)'"
292+
}
293+
else {
294+
$paramsDisk3.Add("DiskId", $dataDisk2Id)
295+
$paramsDisk3.Add("IsOSDisk", $false)
296+
if ([string]::IsNullOrEmpty($dataDisk2Name)) {
297+
$processor.Logger.LogTrace("UPDATED_TARGET_DATA_DISK2_NAME is not mentioned for: '$($sourceMachineName)'")
298+
}else {
299+
$paramsDisk3.Add("TargetDiskName", $dataDisk2Name)
300+
}
301+
$diskMapping+= $paramsDisk3
302+
}
303+
304+
if ($diskMapping.Count -gt 0) {
305+
$params.Add("DiskToUpdate", $diskMapping)
306+
}
307+
238308
$targetMachineName = $csvItem.UPDATED_TARGET_MACHINE_NAME
239309
if ([string]::IsNullOrEmpty($targetMachineName)) {
240310
$processor.Logger.LogTrace("UPDATED_TARGET_MACHINE_NAME is not mentioned for: '$($sourceMachineName)'")
@@ -303,6 +373,15 @@ Function ProcessItemImpl($processor, $csvItem, $reportItem) {
303373
else {
304374
$paramsNIC1.Add("NicId", $UpdatedNIC1ID)
305375
}
376+
377+
$nic1Name = $csvItem.UPDATED_TARGET_NIC1_NAME
378+
if ([string]::IsNullOrEmpty($nic1Name)) {
379+
$processor.Logger.LogTrace("UPDATED_TARGET_NIC1_NAME is not mentioned for: '$($sourceMachineName)'")
380+
}
381+
else {
382+
$paramsNIC1.Add("TargetNicName", $nic1Name)
383+
}
384+
306385
$NIC1_SelectionType = $csvItem.UPDATED_TARGET_NIC1_SELECTIONTYPE
307386
#Specifies whether the NIC to be updated will be the Primary, Secondary or not migrated ("DoNotCreate")
308387
if ([string]::IsNullOrEmpty($NIC1_SelectionType)) {
@@ -347,6 +426,15 @@ Function ProcessItemImpl($processor, $csvItem, $reportItem) {
347426
else {
348427
$paramsNIC2.Add("NicId", $UpdatedNIC2ID)
349428
}
429+
430+
$nic2Name = $csvItem.UPDATED_TARGET_NIC2_NAME
431+
if ([string]::IsNullOrEmpty($nic2Name)) {
432+
$processor.Logger.LogTrace("UPDATED_TARGET_NIC2_NAME is not mentioned for: '$($sourceMachineName)'")
433+
}
434+
else {
435+
$paramsNIC2.Add("TargetNicName", $nic2Name)
436+
}
437+
350438
$NIC2_SelectionType = $csvItem.UPDATED_TARGET_NIC2_SELECTIONTYPE
351439
#Specifies whether the NIC to be updated will be the Primary, Secondary or not migrated ("DoNotCreate")
352440
if ([string]::IsNullOrEmpty($NIC2_SelectionType)) {

‎azure-migrate/migrate-at-scale-vmware-agentles/Agentless VMware automation/Input.csv

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
AZMIGRATEPROJECT_SUBSCRIPTION_ID,AZMIGRATEPROJECT_RESOURCE_GROUP_NAME,AZMIGRATEPROJECT_NAME,SOURCE_MACHINE_NAME,AZMIGRATEASSESSMENT_NAME,AZMIGRATE_APPLIANCE_NAME,AZMIGRATEGROUP_NAME,SQL_SERVER_LICENSE_TYPE,TAG_KEY,TAG_VALUE,VM_TAG_KEY,VM_TAG_VALUE,DISK_TAG_KEY,DISK_TAG_VALUE,NIC_TAG_KEY,NIC_TAG_VALUE,TARGET_SUBSCRIPTION_ID,TARGET_RESOURCE_GROUP_NAME,TARGET_VNET_NAME,TARGET_SUBNET_NAME,TARGET_MACHINE_NAME,TARGET_MACHINE_SIZE,LICENSE_TYPE,OS_DISK_ID,DATA_DISK1_ID,DATA_DISK2_ID,TARGET_DISKTYPE,AVAILABILITYZONE_NUMBER,AVAILABILITYSET_NAME,TURNOFF_SOURCESERVER,TESTMIGRATE_VNET_NAME,UPDATED_TAG_KEY,UPDATED_TAG_VALUE,UPDATED_TAG_OPERATION,UPDATED_VMTAG_KEY,UPDATED_VMTAG_VALUE,UPDATED_VMTAG_OPERATION,UPDATED_DISKTAG_KEY,UPDATED_DISKTAG_VALUE,UPDATED_DISKTAG_OPERATION,UPDATED_NICTAG_KEY,UPDATED_NICTAG_VALUE,UPDATED_NICTAG_OPERATION,UPDATED_TARGET_RESOURCE_GROUP_NAME,UPDATED_TARGET_VNET_NAME,UPDATED_TARGET_MACHINE_NAME,UPDATED_TARGET_DISK_NAME,UPDATED_TARGET_OS_DISK_NAME,UPDATED_TARGET_DATA_DISK1_NAME,UPDATED_TARGET_DATA_DISK2_NAME,UPDATED_TARGET_MACHINE_SIZE,UPDATED_AVAILABILITYZONE_NUMBER,UPDATED_AVAILABILITYSET_NAME,UPDATED_NIC1_ID,UPDATED_TARGET_NIC1_NAME,UPDATED_TARGET_NIC1_SELECTIONTYPE,UPDATED_TARGET_NIC1_SUBNET_NAME,UPDATED_TARGET_NIC1_IP,UPDATED_NIC2_ID,UPDATED_TARGET_NIC2_NAME,UPDATED_TARGET_NIC2_SELECTIONTYPE,UPDATED_TARGET_NIC2_SUBNET_NAME,UPDATED_TARGET_NIC2_IP,OK_TO_UPDATE,OK_TO_MIGRATE,OK_TO_USE_ASSESSMENT,OK_TO_TESTMIGRATE,OK_TO_RETRIEVE_REPLICATIONSTATUS,OK_TO_CLEANUP,OK_TO_TESTMIGRATE_CLEANUP
2-
xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx,srcrg-ecy,ECYPROJ,testvm-cvm3,,sv-app-2,srcrg-ecy,PAYG,,,"vm-tag-1,vm-tag-2","vm-tag-val-1,vm-tag-val-2","d1,d2","d1-val,d2-val",n1,n1-val,xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx,sv-target-ecy-rg,vnet-ecy,default,testvm-1,,NoLicenseType,xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx,xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx,xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx,,,,Y,vnet-ecy,,,,"up-vm-1,up-vm-2","up-vm-value-1,up-vm-value-2",Replace,disk-1,disk-1-tag,Merge,,,,,,testvm-sv-1,,,,,,,,,nic-name-updated,,,,,,,,,Y,Y,Y,Y,Y,Y,Y
1+
AZMIGRATEPROJECT_SUBSCRIPTION_ID,AZMIGRATEPROJECT_RESOURCE_GROUP_NAME,AZMIGRATEPROJECT_NAME,SOURCE_MACHINE_NAME,AZMIGRATEASSESSMENT_NAME,AZMIGRATE_APPLIANCE_NAME,OS_UPGRADE_VERSION,AZMIGRATEGROUP_NAME,SQL_SERVER_LICENSE_TYPE,TAG_KEY,TAG_VALUE,VM_TAG_KEY,VM_TAG_VALUE,DISK_TAG_KEY,DISK_TAG_VALUE,NIC_TAG_KEY,NIC_TAG_VALUE,TARGET_SUBSCRIPTION_ID,TARGET_RESOURCE_GROUP_NAME,TARGET_VNET_NAME,TARGET_SUBNET_NAME,TARGET_MACHINE_NAME,TARGET_MACHINE_SIZE,LICENSE_TYPE,OS_DISK_ID,DATA_DISK1_ID,DATA_DISK2_ID,TARGET_DISKTYPE,AVAILABILITYZONE_NUMBER,AVAILABILITYSET_NAME,TURNOFF_SOURCESERVER,TESTMIGRATE_VNET_NAME,UPDATED_TAG_KEY,UPDATED_TAG_VALUE,UPDATED_TAG_OPERATION,UPDATED_VMTAG_KEY,UPDATED_VMTAG_VALUE,UPDATED_VMTAG_OPERATION,UPDATED_DISKTAG_KEY,UPDATED_DISKTAG_VALUE,UPDATED_DISKTAG_OPERATION,UPDATED_NICTAG_KEY,UPDATED_NICTAG_VALUE,UPDATED_NICTAG_OPERATION,UPDATED_TARGET_RESOURCE_GROUP_NAME,UPDATED_TARGET_VNET_NAME,UPDATED_TARGET_MACHINE_NAME,UPDATED_TARGET_DISK_NAME,UPDATED_TARGET_OS_DISK_NAME,UPDATED_TARGET_DATA_DISK1_NAME,UPDATED_TARGET_DATA_DISK2_NAME,UPDATED_TARGET_MACHINE_SIZE,UPDATED_AVAILABILITYZONE_NUMBER,UPDATED_AVAILABILITYSET_NAME,UPDATED_NIC1_ID,UPDATED_TARGET_NIC1_NAME,UPDATED_TARGET_NIC1_SELECTIONTYPE,UPDATED_TARGET_NIC1_SUBNET_NAME,UPDATED_TARGET_NIC1_IP,UPDATED_NIC2_ID,UPDATED_TARGET_NIC2_NAME,UPDATED_TARGET_NIC2_SELECTIONTYPE,UPDATED_TARGET_NIC2_SUBNET_NAME,UPDATED_TARGET_NIC2_IP,OK_TO_UPDATE,OK_TO_MIGRATE,OK_TO_USE_ASSESSMENT,OK_TO_TESTMIGRATE,OK_TO_RETRIEVE_REPLICATIONSTATUS,OK_TO_CLEANUP,OK_TO_TESTMIGRATE_CLEANUP
2+
xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxx,srcrg-ecy,ECYPROJ,test-ubun22-server-bios-lvm,,sv-app-2,Microsoft Windows Server 2022 (64-bit),srcrg-ecy,PAYG,,,"vm-tag-1,vm-tag-2","vm-tag-val-1,vm-tag-val-2","d1,d2","d1-val,d2-val",n1,n1-val,xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxx,sv-target-ecy-rg,vnet-ecy,default,testvm-1,,NoLicenseType,,,,,,,Y,vnet-ecy,,,,"up-vm-1,up-vm-2","up-vm-value-1,up-vm-value-2",Replace,disk-1,disk-1-tag,Merge,,,,,,testvm-sv-1,,,,,,,,,nic-name-updated,,,,,,,,,Y,Y,Y,Y,Y,Y,Y

0 commit comments

Comments
 (0)