Upgrade V8 to 9.0 #111
Upgrade V8 to 9.0 #111
Conversation
|
@cleiner (FYI @zwang) The build for Windows is failing with the upgrade to V8: What is the process to get the right patches for new versions of V8? I think we need to add more detailed steps to upgrade V8 to latest versions. FYI; I'm using a unix machine. |
| @@ -19,7 +19,7 @@ jobs: | |||
| run: cd deps/depot_tools && git config --unset-all remote.origin.fetch; git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* | |||
| shell: bash | |||
| - name: Build V8 linux | |||
| if: matrix.platform == 'ubuntu-latest' | |||
| if: matrix.platform == 'ubuntu-18.04' | |||
There was a problem hiding this comment.
This can be replaced with runner.os == 'Linux'
There was a problem hiding this comment.
Oooh, nice. Thanks @kuoruan 👍
.... now going to update all my projects
There was a problem hiding this comment.
Do we want to change this before merge? if not, I can merge this PR now.
There was a problem hiding this comment.
I'll address this in another PR later, as we have already run the builds for this version
|
Use then fix others manually. |
Co-authored-by: rogchap <rogchap@users.noreply.github.com>
Co-authored-by: rogchap <rogchap@users.noreply.github.com>
Co-authored-by: rogchap <rogchap@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 12 12
Lines 416 416
=======================================
Hits 402 402
Misses 9 9
Partials 5 5 Continue to review full report at Codecov.
|
fixes #109