Separate blank and lock #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the later reply, will review when I get the time (soonish). |
snprajwal
reviewed
Jul 22, 2024
Co-authored-by: Prajwal S N <prajwalnadig21@gmail.com>
|
Thank you for the changes! @rodlie PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to decouple blanking the screen from locking the screen, because I would like to blank to save power if I step away from the computer briefly, but I don't want to lock the screen automatically until much later.
This PR uses the previous "blank" preference for blanking, and adds a new separate preference for locking.
I also made it possible to lock first and blank later, in case someone has the opposite use case. (This requires
noblankto be set withxset, because the default behaviour is to blank). Sometimes I see a crosshatch pattern before the xsecurelock saver kicks in, but this appears to be a random (?) glitch and not something that powerkit is responsible for. Most of the time the saver is displayed immediately, as expected.