Skip to content

(#771) Set a default dummy ipaddress6 fact #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2019
Merged

(#771) Set a default dummy ipaddress6 fact #772

merged 1 commit into from
Oct 30, 2019

Conversation

rodjek
Copy link
Owner

@rodjek rodjek commented Oct 30, 2019

Puppet 6.9.0 started setting a serverip6 server fact which is set
using the value of the ipaddress6 fact. If the fact set(s) provided by
FacterDB don't have an ipaddress6 fact set, then the normal Facter
fact will be resolved, which can result in Ruby trying to load Windows
only gems on Linux.

Fixes #771

Puppet 6.9.0 started setting a `serverip6` server fact which is set
using the value of the `ipaddress6` fact. If the fact set(s) provided by
FacterDB don't have an `ipaddress6` fact set, then the normal Facter
fact will be resolved, which can result in Ruby trying to load Windows
only gems on Linux.

Fixes #771
@rodjek rodjek added the bugfix label Oct 30, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.5% when pulling 4ef2f36 on gh-771 into 727cb33 on master.

@rodjek rodjek added this to the 2.7.8 milestone Oct 30, 2019
@rodjek rodjek merged commit a4749c8 into master Oct 30, 2019
@rodjek rodjek deleted the gh-771 branch October 30, 2019 09:26
@baurmatt
Copy link
Contributor

baurmatt commented Oct 30, 2019

Thank you! :)

@ekohl
Copy link
Contributor

ekohl commented Dec 19, 2019

How can I unset this? I need to write a test where the ipaddress6 fact is not present.

@ekohl
Copy link
Contributor

ekohl commented Dec 19, 2019

So I found out you can use let(:facts) { {ipaddress6: nil} } if you don't use let(:node) { 'foo.example.com' }. Otherwise it's impossible to override the IPv6 address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks on Puppet > 6.8 for Windows systems
4 participants