Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completion? #9

Closed
benlindsay opened this issue Dec 17, 2017 · 6 comments
Closed

Tab completion? #9

benlindsay opened this issue Dec 17, 2017 · 6 comments

Comments

@benlindsay
Copy link

Is there any chance this supports tab completion? Tab completion works in my normal pass stuff, but not after I've typed pass update ....

Thanks!

@benlindsay
Copy link
Author

Nevermind, an issue in the tail extension explained how to add this. Kind of hacky but it seems like it has to be this way until pass adds direct support for tab completion for extensions? The issue is here: palortoff/pass-extension-tail#4.

If anyone sees this in the future, on my mac the bash completion file was at /usr/local/etc/bash_completion.d/pass, and I changed line 84 to look like this:

local commands="init ls find grep show insert generate edit rm mv cp git help version update tail tailedit"

(adding update for this plugin, and tail an tailedit for the other plugin)

and line 97 to look like this:

ls|list|edit|update|tail|tailedit)

(same thing here).

@roddhjav
Copy link
Owner

roddhjav commented Dec 18, 2017

Many thank for this information. I did the same kind of hacked completion for zsh. But right now, we need pass support.

I'm reopening this issue because I plan to work on it in the future.

@roddhjav roddhjav reopened this Dec 18, 2017
@benlindsay
Copy link
Author

Also, mostly as just a note for future me, I had issues getting this hack to work properly on my mac unless bash and bash-completion were installed via homebrew, and my shell was running from /usr/local/bin/bash instead of /bin/bash

@roddhjav
Copy link
Owner

roddhjav commented Oct 19, 2018

This is now natively supported by pass. I did a WIP implementation in #20

@roddhjav
Copy link
Owner

roddhjav commented Dec 9, 2018

This is now implemented.

@roddhjav roddhjav closed this as completed Dec 9, 2018
@NilsIrl
Copy link

NilsIrl commented Jan 26, 2020

For reference this was implemented in e811393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants