fix(solid): Use memo to ensure minimal updates #5241
Merged
+45
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new code is ,ore straight forward and avoids makes it very explicit when we recreate the view. This should fix the flickering issue seen in https://bugs.rocicorp.dev/p/zero/issue/4085
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bencher Report| Branch | arv/solid-memo |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 1,750.12 KB(-0.01%)Baseline: 1,750.26 KB | 1,785.27 KB (98.03%) |
| zero.js | 📈 view plot 🚷 view threshold | 237.70 KB(0.00%)Baseline: 237.70 KB | 242.45 KB (98.04%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 65.69 KB(0.00%)Baseline: 65.69 KB | 67.00 KB (98.04%) |
|
| Branch | arv/solid-memo |
| Testbed | self-hosted |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| zqlite: push into limited query, outside the bound | Throughput operations / second (ops/s) x 1e3 | 📈 plot 🚷 threshold 🚨 alert (🔔) | 132.97 ops/s x 1e3(-13.06%)Baseline: 152.95 ops/s x 1e3 | 134.42 ops/s x 1e3 (101.09%) |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Lower Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|
| zpg: (pk lookup) select * from track where id = 3163 | 📈 view plot 🚷 view threshold | 887.37 ops/s(-1.79%)Baseline: 903.51 ops/s | 745.66 ops/s (84.03%) |
| zpg: (secondary index lookup) select * from track where album_id = 248 | 📈 view plot 🚷 view threshold | 959.69 ops/s(+2.12%)Baseline: 939.79 ops/s | 812.23 ops/s (84.64%) |
| zpg: (table scan) select * from album | 📈 view plot 🚷 view threshold | 724.62 ops/s(+2.45%)Baseline: 707.28 ops/s | 609.61 ops/s (84.13%) |
| zpg: OR with empty branch and limit | 📈 view plot 🚷 view threshold | 857.44 ops/s(+2.99%)Baseline: 832.58 ops/s | 704.92 ops/s (82.21%) |
| zpg: OR with empty branch and limit with exists | 📈 view plot 🚷 view threshold | 598.16 ops/s(-12.73%)Baseline: 685.46 ops/s | 553.10 ops/s (92.47%) |
| zpg: all playlists | 📈 view plot 🚷 view threshold | 5.76 ops/s(-0.18%)Baseline: 5.77 ops/s | 5.61 ops/s (97.33%) |
| zpg: scan with one depth related | 📈 view plot 🚷 view threshold | 407.14 ops/s(-3.88%)Baseline: 423.59 ops/s | 383.41 ops/s (94.17%) |
| zql: (pk lookup) select * from track where id = 3163 | 📈 view plot 🚷 view threshold | 124,977.30 ops/s(-2.80%)Baseline: 128,583.55 ops/s | 104,476.30 ops/s (83.60%) |
| zql: (secondary index lookup) select * from track where album_id = 248 | 📈 view plot 🚷 view threshold | 2,273.81 ops/s(+3.89%)Baseline: 2,188.61 ops/s | 1,562.81 ops/s (68.73%) |
| zql: (table scan) select * from album | 📈 view plot 🚷 view threshold | 6,860.26 ops/s(-1.10%)Baseline: 6,936.35 ops/s | 6,286.39 ops/s (91.63%) |
| zql: OR with empty branch and limit | 📈 view plot 🚷 view threshold | 51,121.76 ops/s(-12.30%)Baseline: 58,294.01 ops/s | 42,251.53 ops/s (82.65%) |
| zql: OR with empty branch and limit with exists | 📈 view plot 🚷 view threshold | 12,177.87 ops/s(-2.17%)Baseline: 12,447.81 ops/s | 9,449.08 ops/s (77.59%) |
| zql: all playlists | 📈 view plot 🚷 view threshold | 4.46 ops/s(-1.41%)Baseline: 4.52 ops/s | 4.07 ops/s (91.30%) |
| zql: edit for limited query, inside the bound | 📈 view plot 🚷 view threshold | 226,117.10 ops/s(-5.22%)Baseline: 238,574.07 ops/s | 219,390.43 ops/s (97.03%) |
| zql: edit for limited query, outside the bound | 📈 view plot 🚷 view threshold | 229,311.65 ops/s(-8.60%)Baseline: 250,888.63 ops/s | 209,565.48 ops/s (91.39%) |
| zql: push into limited query, inside the bound | 📈 view plot 🚷 view threshold | 114,080.56 ops/s(-3.52%)Baseline: 118,243.32 ops/s | 111,662.32 ops/s (97.88%) |
| zql: push into limited query, outside the bound | 📈 view plot 🚷 view threshold | 426,603.21 ops/s(-7.63%)Baseline: 461,856.39 ops/s | 400,036.32 ops/s (93.77%) |
| zql: push into unlimited query | 📈 view plot 🚷 view threshold | 351,052.37 ops/s(-4.78%)Baseline: 368,676.33 ops/s | 338,311.81 ops/s (96.37%) |
| zql: scan with one depth related | 📈 view plot 🚷 view threshold | 466.66 ops/s(-6.85%)Baseline: 500.98 ops/s | 417.35 ops/s (89.43%) |
| zqlite: (pk lookup) select * from track where id = 3163 | 📈 view plot 🚷 view threshold | 46,301.92 ops/s(-1.99%)Baseline: 47,243.84 ops/s | 41,239.90 ops/s (89.07%) |
| zqlite: (secondary index lookup) select * from track where album_id = 248 | 📈 view plot 🚷 view threshold | 11,663.59 ops/s(+0.64%)Baseline: 11,589.79 ops/s | 10,332.80 ops/s (88.59%) |
| zqlite: (table scan) select * from album | 📈 view plot 🚷 view threshold | 1,297.09 ops/s(-6.46%)Baseline: 1,386.73 ops/s | 1,260.66 ops/s (97.19%) |
| zqlite: OR with empty branch and limit | 📈 view plot 🚷 view threshold | 18,145.05 ops/s(-6.87%)Baseline: 19,482.82 ops/s | 15,789.47 ops/s (87.02%) |
| zqlite: OR with empty branch and limit with exists | 📈 view plot 🚷 view threshold | 5,962.20 ops/s(+4.90%)Baseline: 5,683.55 ops/s | 4,307.41 ops/s (72.25%) |
| zqlite: all playlists | 📈 view plot 🚷 view threshold | 1.51 ops/s(+0.17%)Baseline: 1.51 ops/s | 1.41 ops/s (93.22%) |
| zqlite: edit for limited query, inside the bound | 📈 view plot 🚷 view threshold | 122,366.67 ops/s(-4.22%)Baseline: 127,761.55 ops/s | 118,278.15 ops/s (96.66%) |
| zqlite: edit for limited query, outside the bound | 📈 view plot 🚷 view threshold | 124,399.09 ops/s(-4.99%)Baseline: 130,937.98 ops/s | 120,375.96 ops/s (96.77%) |
| zqlite: push into limited query, inside the bound | 📈 view plot 🚷 view threshold | 4,402.95 ops/s(+2.85%)Baseline: 4,280.82 ops/s | 4,110.88 ops/s (93.37%) |
| zqlite: push into limited query, outside the bound | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 132,974.84 ops/s(-13.06%)Baseline: 152,946.22 ops/s | 134,421.58 ops/s (101.09%) |
| zqlite: push into unlimited query | 📈 view plot 🚷 view threshold | 127,466.04 ops/s(-5.03%)Baseline: 134,220.79 ops/s | 123,417.68 ops/s (96.82%) |
| zqlite: scan with one depth related | 📈 view plot 🚷 view threshold | 146.82 ops/s(-11.26%)Baseline: 165.45 ops/s | 131.41 ops/s (89.51%) |
|
| Branch | arv/solid-memo |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) x 1e3 (Result Δ%) | Lower Boundary operations / second (ops/s) x 1e3 (Limit %) |
|---|---|---|---|
| src/client/custom.bench.ts > big schema | 📈 view plot 🚷 view threshold | 924.59 ops/s x 1e3(+7.02%)Baseline: 863.94 ops/s x 1e3 | 648.87 ops/s x 1e3 (70.18%) |
| src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 3.00 ops/s x 1e3(+1.33%)Baseline: 2.96 ops/s x 1e3 | 2.82 ops/s x 1e3 (94.20%) |
| src/client/zero.bench.ts > pk compare > pk = N | 📈 view plot 🚷 view threshold | 48.42 ops/s x 1e3(+4.83%)Baseline: 46.19 ops/s x 1e3 | 40.91 ops/s x 1e3 (84.48%) |
| src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 3.93 ops/s x 1e3(-5.08%)Baseline: 4.14 ops/s x 1e3 | 3.83 ops/s x 1e3 (97.68%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new code is ,ore straight forward and avoids makes it very explicit when we recreate the view. This should fix the flickering issue seen in
https://bugs.rocicorp.dev/p/zero/issue/4085