Skip to content

Conversation

@0xcadams
Copy link
Member

@0xcadams 0xcadams commented Nov 26, 2025

Renames all user-facing "get queries" to "query". Keeps old config with deprecation notice.

@0xcadams 0xcadams requested review from aboodman and arv November 26, 2025 18:14
@vercel
Copy link

vercel bot commented Nov 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
replicache-docs Ready Ready Preview Comment Dec 1, 2025 7:14pm
zbugs Ready Ready Preview Comment Dec 1, 2025 7:14pm

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

🐰 Bencher Report

Branch0xcadams/get-queries-rename
TestbedLinux
Click to view all benchmark results
BenchmarkFile SizeBenchmark Result
kilobytes (KB)
(Result Δ%)
Upper Boundary
kilobytes (KB)
(Limit %)
zero-package.tgz📈 view plot
🚷 view threshold
1,750.86 KB
(+0.01%)Baseline: 1,750.63 KB
1,785.64 KB
(98.05%)
zero.js📈 view plot
🚷 view threshold
237.74 KB
(+0.01%)Baseline: 237.72 KB
242.47 KB
(98.05%)
zero.js.br📈 view plot
🚷 view threshold
65.72 KB
(+0.02%)Baseline: 65.70 KB
67.01 KB
(98.06%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

🐰 Bencher Report

Branch0xcadams/get-queries-rename
Testbedself-hosted

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Lower Boundary
(Limit %)
zql: all playlistsThroughput
operations / second (ops/s)
📈 plot
🚷 threshold
🚨 alert (🔔)
4.04 ops/s
(-10.57%)Baseline: 4.51 ops/s
4.04 ops/s
(100.05%)

Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
zpg: (pk lookup) select * from track where id = 3163📈 view plot
🚷 view threshold
889.79 ops/s
(-1.52%)Baseline: 903.55 ops/s
745.72 ops/s
(83.81%)
zpg: (secondary index lookup) select * from track where album_id = 248📈 view plot
🚷 view threshold
963.16 ops/s
(+2.48%)Baseline: 939.84 ops/s
812.24 ops/s
(84.33%)
zpg: (table scan) select * from album📈 view plot
🚷 view threshold
696.17 ops/s
(-1.50%)Baseline: 706.80 ops/s
609.23 ops/s
(87.51%)
zpg: OR with empty branch and limit📈 view plot
🚷 view threshold
732.96 ops/s
(-11.74%)Baseline: 830.50 ops/s
699.51 ops/s
(95.44%)
zpg: OR with empty branch and limit with exists📈 view plot
🚷 view threshold
710.82 ops/s
(+3.42%)Baseline: 687.33 ops/s
557.59 ops/s
(78.44%)
zpg: all playlists📈 view plot
🚷 view threshold
5.75 ops/s
(-0.35%)Baseline: 5.77 ops/s
5.61 ops/s
(97.49%)
zpg: scan with one depth related📈 view plot
🚷 view threshold
442.05 ops/s
(+4.22%)Baseline: 424.17 ops/s
383.94 ops/s
(86.85%)
zql: (pk lookup) select * from track where id = 3163📈 view plot
🚷 view threshold
123,172.89 ops/s
(-4.19%)Baseline: 128,553.47 ops/s
104,414.19 ops/s
(84.77%)
zql: (secondary index lookup) select * from track where album_id = 248📈 view plot
🚷 view threshold
2,224.86 ops/s
(+1.69%)Baseline: 2,187.79 ops/s
1,562.45 ops/s
(70.23%)
zql: (table scan) select * from album📈 view plot
🚷 view threshold
7,049.62 ops/s
(+1.59%)Baseline: 6,939.51 ops/s
6,289.07 ops/s
(89.21%)
zql: OR with empty branch and limit📈 view plot
🚷 view threshold
49,856.22 ops/s
(-14.44%)Baseline: 58,272.92 ops/s
42,171.94 ops/s
(84.59%)
zql: OR with empty branch and limit with exists📈 view plot
🚷 view threshold
12,052.41 ops/s
(-3.16%)Baseline: 12,445.72 ops/s
9,445.66 ops/s
(78.37%)
zql: all playlists📈 view plot
🚷 view threshold
🚨 view alert (🔔)
4.04 ops/s
(-10.57%)Baseline: 4.51 ops/s
4.04 ops/s
(100.05%)

zql: edit for limited query, inside the bound📈 view plot
🚷 view threshold
242,939.95 ops/s
(+1.71%)Baseline: 238,854.45 ops/s
220,023.86 ops/s
(90.57%)
zql: edit for limited query, outside the bound📈 view plot
🚷 view threshold
252,113.14 ops/s
(+0.34%)Baseline: 251,268.65 ops/s
210,494.26 ops/s
(83.49%)
zql: push into limited query, inside the bound📈 view plot
🚷 view threshold
119,542.35 ops/s
(+1.02%)Baseline: 118,334.34 ops/s
111,871.26 ops/s
(93.58%)
zql: push into limited query, outside the bound📈 view plot
🚷 view threshold
503,806.29 ops/s
(+8.78%)Baseline: 463,143.11 ops/s
401,001.94 ops/s
(79.59%)
zql: push into unlimited query📈 view plot
🚷 view threshold
366,108.82 ops/s
(-0.76%)Baseline: 368,927.27 ops/s
339,049.66 ops/s
(92.61%)
zql: scan with one depth related📈 view plot
🚷 view threshold
504.53 ops/s
(+0.58%)Baseline: 501.62 ops/s
418.66 ops/s
(82.98%)
zqlite: (pk lookup) select * from track where id = 3163📈 view plot
🚷 view threshold
46,646.84 ops/s
(-1.28%)Baseline: 47,249.59 ops/s
41,249.88 ops/s
(88.43%)
zqlite: (secondary index lookup) select * from track where album_id = 248📈 view plot
🚷 view threshold
11,343.71 ops/s
(-2.08%)Baseline: 11,584.45 ops/s
10,325.45 ops/s
(91.02%)
zqlite: (table scan) select * from album📈 view plot
🚷 view threshold
1,275.25 ops/s
(-8.01%)Baseline: 1,386.37 ops/s
1,258.65 ops/s
(98.70%)
zqlite: OR with empty branch and limit📈 view plot
🚷 view threshold
17,874.01 ops/s
(-8.24%)Baseline: 19,478.31 ops/s
15,774.68 ops/s
(88.25%)
zqlite: OR with empty branch and limit with exists📈 view plot
🚷 view threshold
4,889.00 ops/s
(-13.71%)Baseline: 5,665.66 ops/s
4,271.14 ops/s
(87.36%)
zqlite: all playlists📈 view plot
🚷 view threshold
1.47 ops/s
(-2.83%)Baseline: 1.51 ops/s
1.41 ops/s
(96.03%)
zqlite: edit for limited query, inside the bound📈 view plot
🚷 view threshold
128,311.52 ops/s
(+0.35%)Baseline: 127,860.63 ops/s
118,526.08 ops/s
(92.37%)
zqlite: edit for limited query, outside the bound📈 view plot
🚷 view threshold
133,646.98 ops/s
(+1.95%)Baseline: 131,092.11 ops/s
120,697.64 ops/s
(90.31%)
zqlite: push into limited query, inside the bound📈 view plot
🚷 view threshold
4,282.69 ops/s
(+0.09%)Baseline: 4,278.81 ops/s
4,113.18 ops/s
(96.04%)
zqlite: push into limited query, outside the bound📈 view plot
🚷 view threshold
149,165.13 ops/s
(-2.64%)Baseline: 153,216.06 ops/s
135,720.41 ops/s
(90.99%)
zqlite: push into unlimited query📈 view plot
🚷 view threshold
123,134.73 ops/s
(-8.21%)Baseline: 134,148.60 ops/s
123,011.21 ops/s
(99.90%)
zqlite: scan with one depth related📈 view plot
🚷 view threshold
165.93 ops/s
(+0.10%)Baseline: 165.77 ops/s
132.23 ops/s
(79.69%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

🐰 Bencher Report

Branch0xcadams/get-queries-rename
Testbedself-hosted
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
src/client/custom.bench.ts > big schema📈 view plot
🚷 view threshold
930.90 ops/s x 1e3
(+7.74%)Baseline: 864.05 ops/s x 1e3
648.80 ops/s x 1e3
(69.70%)
src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers)📈 view plot
🚷 view threshold
2.83 ops/s x 1e3
(-4.33%)Baseline: 2.95 ops/s x 1e3
2.81 ops/s x 1e3
(99.58%)
src/client/zero.bench.ts > pk compare > pk = N📈 view plot
🚷 view threshold
46.61 ops/s x 1e3
(+0.97%)Baseline: 46.16 ops/s x 1e3
40.92 ops/s x 1e3
(87.79%)
src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers)📈 view plot
🚷 view threshold
4.40 ops/s x 1e3
(+6.12%)Baseline: 4.14 ops/s x 1e3
3.84 ops/s x 1e3
(87.31%)
🐰 View full continuous benchmarking report in Bencher

@aboodman
Copy link
Contributor

aboodman commented Nov 26, 2025 via email

@aboodman
Copy link
Contributor

So we will have:

cacheURL
queryURL
mutateURL

Copy link
Contributor

@aboodman aboodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

queries->query otherwise lgtm

@0xcadams 0xcadams changed the title feat(zero): rename get-queries to queries feat(zero): rename get-queries to query Nov 27, 2025
Copy link
Contributor

@arv arv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xcadams 0xcadams force-pushed the 0xcadams/get-queries-rename branch from 4bce948 to 8d03501 Compare December 1, 2025 18:57
github-token: ${{ secrets.PERSONAL_GITHUB_TOKEN }}
source: 'main'
dest: 'gigabugs'
- name: Mirror main to sandbox
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just the output of running prettier across all GH workflow defs

Merged via the queue into main with commit 79de142 Dec 1, 2025
17 of 18 checks passed
@0xcadams 0xcadams deleted the 0xcadams/get-queries-rename branch December 1, 2025 20:04
0xcadams added a commit that referenced this pull request Dec 1, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 1, 2025
This reverts commit 79de142. There is a
failing configuration. We need to update the deploy to allow queries to
point to this new URL.
github-merge-queue bot pushed a commit that referenced this pull request Dec 1, 2025
Reopening #5230 due to a deploy
configuration issue for the query URL.

---

Renames all user-facing "get queries" to "query". Keeps old config with
deprecation notice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants